Review main Abandoned

59173[TASK] Add git setup script for core development

Sybille Peters CR 0 V 0 Normal +193 −0 updated 10/19/19, 08:20

Commit message

This script sets up the git environment. For example it
sets user.name, user.email, copies commit-msg hook etc.

Several variables must be set in advance:

T3CORE_FULLNAME="John Doe"
T3CORE_EMAIL=john@yahoo.com
T3CORE_GERRIT_USERNAME=jdoe
T3CORE_COMMIT_TEMPLATE=~/t3core-commit-msg-template

You can do one of the following:

1) Set the variables when calling the script:
   T3CORE_FULLNAME="John Doe" Build/Scripts/setupGit.sh

2) Set the variables with export in a setup script (e.g. ~/.bashrc)

3) Set the variables in a config file which is specified
   with -c:

   Build/Scripts/setupGit.sh -c ~/t3core-config.sh

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Sybille Peters uploaded patch set 1 12/16/18, 22:41

  2. TYPO3com voted on patch set 1 V +1 12/16/18, 22:51 Completed build in 10m 16s on Sun, 16 Dec, 11:51 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30755

  3. Josef Glatz commented on patch set 1 12/16/18, 23:30

    What about adding the entry point to the already known composer scripts section https://git.typo3.org/Packages/TYPO3.CMS.git/blob/HEAD:/composer.json ?
  4. Sybille Peters commented on patch set 1 12/17/18, 07:58

    @Josef I don't quite know what do you mean "adding the entry point ..."? I assume you mean the already existing composer commands for setting up the commit hook etc.? My plan was to have *one* command (script) and not have to execute 6 or 7 commands. The composer commands for setting up the commit hook etc. are cool, however the git setup is still a little tedious, so this script handles that part and only that part. I don't want to reuse the composer commands in the script because that adds additional dependencies which are unnecessary.
  5. Josef Glatz commented on patch set 1 12/17/18, 09:54

    > @Josef I don't quite know what do you mean "adding the entry point > ..."? I assume you mean the already existing composer commands for > setting up the commit hook etc.? > > My plan was to have *one* command (script) and not have to execute > 6 or 7 commands. The composer commands for setting up the commit > hook etc. are cool, however the git setup is still a little > tedious, so this script handles that part and only that part. I > don't want to reuse the composer commands in the script because > that adds additional dependencies which are unnecessary. K, I understand. A simple script would makes more sense
  6. Mathias Brodala commented on patch set 1 12/17/18, 09:57

    > I > don't want to reuse the composer commands in the script because > that adds additional dependencies which are unnecessary. Since Composer is mandatory anyways I don't understand this point. I'd also prefer to have a Composer command to execute this script. This way we are free to move or even reimplement it later.
  7. Josef Glatz commented on patch set 1 12/17/18, 10:22

    If we use PHP - what about a Symfony Console based command? Would that be a good idea in this area?
  8. Sybille Peters abandoned the change 10/19/19, 08:20

    Not sure if this is the right approach and it does not look like it will get merged any time soon. It might be better to regroup on Slack and create a separate project. If anyone would like to continue, feel free to open or create a new patch.