Review main Merged

59174[TASK] Streamline dependencies in package.json

Benni Mack CR +2 V +2 Easy +6 −2 updated 12/17/18, 12:16

Commit message

Several changes to Build/package.json are
adapted:
- define compatible node/yarn versions
- adapt version and URL to typo3.org

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
    • Matthias Stegmann +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • Matthias Stegmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 12/17/18, 07:51

  2. Andreas Kienast voted on patch set 1 CR +1 12/17/18, 07:58

  3. Andreas Kienast voted on patch set 1 V +1 12/17/18, 08:00

  4. TYPO3com voted on patch set 1 V -1 12/17/18, 08:01 Completed build in 09m 48s on Mon, 17 Dec, 09:01 AM Test Summary: 48689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30758

  5. Benni Mack commented on patch set 2 12/17/18, 11:10

    Published edit on patch set 1.
  6. TYPO3com voted on patch set 2 V +1 12/17/18, 11:22 Completed build in 11m 13s on Mon, 17 Dec, 12:22 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30764

  7. Benni Mack commented on patch set 2 12/17/18, 11:51

    We decided to stick with node8 for the time being, and fixate that, until the bamboo docker images are split later-on
  8. Andreas Kienast voted on patch set 2 V +1 CR +1 12/17/18, 12:08

  9. Matthias Stegmann voted on patch set 2 V +1 CR +1 12/17/18, 12:16

  10. Benni Mack voted on patch set 2 V +2 CR +2 12/17/18, 12:16

  11. Benni Mack merged patch set 3 12/17/18, 12:16

  12. Benni Mack commented on patch set 3 12/17/18, 12:16

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit d05ccb36a669519d65cae508927e0f91e6eb152c