Review 9.5 Merged

59181[BUGFIX] Do not depend on global TSFE for link generation

Wouter Wolters CR +2 V +2 Normal +33 −28 updated 12/17/18, 13:10

Commit message

Handing in the dependency of TSFE into
AbstractLinkBuilder allows to use a custom TSFE
object, when working within middlewares (e.g. Redirects)
thus, not depending on global state directly.

As a drive-by-fix, using AbstractTypolinkBuilder now does not
generate a global TSFE anymore, which can have ugly side-effects.

Tests are now simplified because the original constructor can be
called directly instead of relying on $GLOBALS[TSFE].

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Wouter Wolters commented on patch set 1 12/17/18, 12:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 12/17/18, 12:47 Completed build in 17m 47s on Mon, 17 Dec, 01:47 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-24

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 12/17/18, 13:10

  4. Wouter Wolters merged patch set 2 12/17/18, 13:10