Review TYPO3_8-7 Merged

59183[BUGFIX] Prevent FrontendUserImageUpdateWizard to be marked as done

Nicole Hummel CR +2 V +2 Easy +3 −1 updated 01/24/19, 16:14

Commit message

This patch prevents the FrontendUserImageUpdateWizard to be marked
as done if error(s) occurred and some relations were not migrated
properly.

Review

  • Code review CR +2
    • Markus Klein +2
    • Josef Glatz +1
  • Verified V +2
    • Markus Klein +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Nicole Hummel uploaded patch set 1 12/17/18, 15:01

  2. TYPO3com voted on patch set 1 V -1 12/17/18, 15:01 Completed build in 16s on Mon, 17 Dec, 04:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3338

  3. Nicole Hummel commented on patch set 1 CR -1 12/17/18, 15:01

    This needs a proper approach in master first
  4. Nicole Hummel uploaded patch set 2 12/17/18, 15:03

  5. Nicole Hummel updated the commit message in patch set 3 12/17/18, 15:04

  6. TYPO3com voted on patch set 2 V +1 12/17/18, 15:22 Completed build in 18m 59s on Mon, 17 Dec, 04:22 PM Test Summary: 79446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3339

  7. TYPO3com voted on patch set 3 V +1 12/17/18, 15:30 Completed build in 25m 50s on Mon, 17 Dec, 04:30 PM Test Summary: 79446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3340

  8. Markus Klein voted on patch set 3 V +1 CR +1 12/17/18, 19:10

  9. Josef Glatz commented on patch set 3 CR -1 01/24/19, 07:44

    Could u please add steps to reproduce such scenario?
  10. Josef Glatz voted on patch set 3 CR +1 01/24/19, 07:45

  11. Josef Glatz commented on patch set 3 01/24/19, 07:46

    ah sorry - forgot to show into issue ¯\_(ツ)_/¯.
  12. Josef Glatz voted on patch set 3 V +1 01/24/19, 10:36

  13. Markus Klein voted on patch set 3 V +2 CR +2 01/24/19, 12:52

  14. Markus Klein merged patch set 4 01/24/19, 12:52

  15. Markus Klein commented on patch set 4 01/24/19, 16:14

    sorry, I totally overlooked that there is no master patch...