Review main Merged

59184[TASK] Add acceptance test for Template and Sites creation

Steffen Dietrich CR +2 V +2 Normal +60 −9 updated 12/19/18, 11:52

Commit message

Extends the existing site configuration acceptance test
by adding a default FE ts snipped and verifying FE is
rendered.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1322

  1. Steffen Dietrich uploaded patch set 1 12/17/18, 16:31

  2. TYPO3com voted on patch set 1 V -1 12/17/18, 16:31 Completed build in 09s on Mon, 17 Dec, 05:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30771

  3. Steffen Dietrich rebased onto patch set 2 12/17/18, 16:33

  4. TYPO3com commented on patch set 2 12/17/18, 16:33 Completed build in 09s on Mon, 17 Dec, 05:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30772

  5. Steffen Dietrich rebased onto patch set 3 12/17/18, 16:54

  6. TYPO3com commented on patch set 3 12/17/18, 16:54 Completed build in 09s on Mon, 17 Dec, 05:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30773

  7. Steffen Dietrich uploaded patch set 4 12/17/18, 17:07

  8. TYPO3com voted on patch set 4 V +1 12/17/18, 17:18 Completed build in 11m 07s on Mon, 17 Dec, 06:18 PM Test Summary: 48761 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30774

  9. Joerg Kummer voted on patch set 4 V +1 CR +1 12/18/18, 09:49

  10. Christian Kuhn commented on patch set 4 CR -1 12/19/18, 09:06

    DefaultAbstractFrontendRenderingCest.php:24

    couldn't we skip that class and merge it into the other one? i don't see a good reason for this separation.
  11. Steffen Dietrich uploaded patch set 5 12/19/18, 10:08

  12. TYPO3com voted on patch set 5 V -1 12/19/18, 10:23 Completed build in 13m 42s on Wed, 19 Dec, 11:23 AM Test Summary: 3910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30830

  13. TYPO3com commented on patch set 5 12/19/18, 10:31 Completed build in 35m 34s on Wed, 19 Dec, 11:31 AM Test Summary: 3910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30830

  14. TYPO3com voted on patch set 5 V +1 12/19/18, 10:59 Completed build in 11m 49s on Wed, 19 Dec, 11:59 AM Test Summary: 48584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30834

  15. Christian Kuhn commented on patch set 5 CR -1 12/19/18, 11:09

    on it.
  16. Christian Kuhn uploaded patch set 6 12/19/18, 11:21

  17. TYPO3com voted on patch set 6 V -1 12/19/18, 11:22 Completed build in 09s on Wed, 19 Dec, 12:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30838

  18. Christian Kuhn uploaded patch set 7 12/19/18, 11:28

  19. TYPO3com voted on patch set 7 V +1 12/19/18, 11:39 Completed build in 10m 15s on Wed, 19 Dec, 12:39 PM Test Summary: 48583 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30839

  20. Christian Kuhn voted on patch set 7 V +1 CR +1 12/19/18, 11:49

  21. Anja Leichsenring voted on patch set 7 V +2 CR +2 12/19/18, 11:52

  22. Anja Leichsenring merged patch set 8 12/19/18, 11:52