Review main Merged

59186[BUGFIX] Do not try to delete already remove file

Helmut Hummel CR +2 V +2 Easy +0 −1 updated 12/18/18, 06:50

Commit message

When using the FAL API to add a file to a folder,
the local file is deleted by default already.

Thus the attempt to remove the file again results in a warning.

Therefore remove the obsolete unlink to avoid the warning.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Guido Schmechel +1
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Helmut Hummel uploaded patch set 1 12/17/18, 21:33

  2. Wouter Wolters voted on patch set 1 CR +1 12/17/18, 21:34

  3. TYPO3com voted on patch set 1 V +1 12/17/18, 21:46 Completed build in 13m 04s on Mon, 17 Dec, 10:46 PM Test Summary: 48760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30780

  4. Guido Schmechel voted on patch set 1 CR +1 12/17/18, 21:51

  5. Markus Klein commented on patch set 1 12/17/18, 22:00

    Please add a note to the commit message which code takes care of the deletion. That's not clear to me reading the patch only
  6. Georg Ringer voted on patch set 1 V +1 CR +1 12/18/18, 05:19

  7. Benni Mack voted on patch set 1 V +2 CR +2 12/18/18, 06:49

  8. Benni Mack merged patch set 2 12/18/18, 06:49

  9. Benni Mack commented on patch set 2 12/18/18, 06:50

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 9bb61ff5e912c78dd86557e5c93d25310b9bef30