Review TYPO3_8-7 Merged

59192[BUGFIX] Do not try to delete already remove file

Benni Mack CR +2 V +2 Easy +0 −1 updated 12/18/18, 07:57

Commit message

When using the FAL API to add a file to a folder,
the local file is deleted by default already.

Thus the attempt to remove the file again results in a warning.

Therefore remove the obsolete unlink to avoid the warning.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 12/18/18, 07:08

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V -1 12/18/18, 07:32 Completed build in 24m 07s on Tue, 18 Dec, 08:32 AM Test Summary: 6 of 79994 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3344

  3. TYPO3com voted on patch set 1 V +1 12/18/18, 07:50 Completed build in 1h 05m 31s on Tue, 18 Dec, 08:50 AM Test Summary: 79446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3344

  4. Benni Mack voted on patch set 1 V +2 CR +2 12/18/18, 07:57

  5. Benni Mack merged patch set 2 12/18/18, 07:57