Review main Merged

59202[TASK] Do not show error when copying a record was succesful

Christoph Lehmann CR +2 V +2 Easy +0 −3 updated 12/20/18, 10:23

Commit message

https://review.typo3.org/#/c/32356/ introduced the log message

The change was about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language

Due to https://review.typo3.org/#/c/51070/ $overrideValues contains

['l10n_source' => 0]

When an element is copied inside an earlier copyRecord() call
the error log message is generated which leads to an error
flash message editors see when copying a page, but everything
(copying the records once) went fine.

A earlier call of copyRecord() can occur when using extension like
gridelements when copying a content element laying inside a
grid container element.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Christian Lange +1
    • Rémy DANIEL +1
    • Marcel Tams +1
  • Verified V +2
    • Mathias Brodala +2
    • Christian Lange +1
    • Marcel Tams +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Christoph Lehmann uploaded patch set 1 12/18/18, 22:55

  2. TYPO3com voted on patch set 1 V +1 12/18/18, 23:07 Completed build in 11m 51s on Wed, 19 Dec, 12:07 AM Test Summary: 48676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30811

  3. Mathias Brodala commented on patch set 1 CR -1 12/19/18, 08:32

    This must be "master, 9.5" instead, not sure if this can also go into 8.7 by now.
  4. Christoph Lehmann updated the commit message in patch set 2 12/19/18, 08:37

  5. Marcel Tams commented on patch set 1 V +1 CR +1 12/19/18, 08:38

    This should definitely go into 8.7 instantly!
  6. Mathias Brodala commented on patch set 2 12/19/18, 08:41

    > This should definitely go into 8.7 instantly! Then you should vote on the newest patch set too. ;-)
  7. Marcel Tams commented on patch set 2 V +1 CR +1 12/19/18, 08:43

    Patchset #2 should definitely go into 8.7 instantly! :)
  8. TYPO3com voted on patch set 2 V +1 12/19/18, 08:48 Completed build in 11m 36s on Wed, 19 Dec, 09:48 AM Test Summary: 48582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30824

  9. Christian Lange voted on patch set 2 V +1 CR +1 12/19/18, 09:46

  10. Rémy DANIEL voted on patch set 2 CR +1 12/19/18, 20:18

  11. Mathias Brodala voted on patch set 2 V +2 CR +2 12/20/18, 10:22

  12. Mathias Brodala merged patch set 3 12/20/18, 10:22

  13. Mathias Brodala commented on patch set 3 12/20/18, 10:23

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit d759b0c1a026332a0f61d9e684b2f65ca2ea6f78
  14. Mathias Brodala commented on patch set 3 12/20/18, 10:23

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 189bf3771a9bbd728d6fac216dcb4e4737fade3d