Review TYPO3_8-7 Merged

59235[TASK] Do not show error when copying a record was successful

Mathias Brodala CR +2 V +2 Easy +0 −3 updated 12/20/18, 11:26

Commit message

https://review.typo3.org/#/c/32356/ introduced the log message

The change was about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language

Due to https://review.typo3.org/#/c/51070/ $overrideValues contains

['l10n_source' => 0]

When an element is copied inside an earlier copyRecord() call
the error log message is generated which leads to an error
flash message editors see when copying a page, but everything
(copying the records once) went fine.

A earlier call of copyRecord() can occur when using extension like
gridelements when copying a content element laying inside a
grid container element.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Christoph Lehmann +1
  • Verified V +2
    • Mathias Brodala +2
    • Christoph Lehmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Mathias Brodala commented on patch set 1 12/20/18, 10:23

    Cherry Picked from branch master.
  2. Christoph Lehmann voted on patch set 1 V +1 CR +1 12/20/18, 10:24

  3. TYPO3com voted on patch set 1 V +1 12/20/18, 10:54 Completed build in 27m 09s on Thu, 20 Dec, 11:54 AM Test Summary: 79446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3349

  4. Mathias Brodala voted on patch set 1 V +2 CR +2 12/20/18, 11:26

  5. Mathias Brodala merged patch set 2 12/20/18, 11:26