59237[BUGFIX] Exclude logger from serialize on save for scheduler task
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Chris Müller +1
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Chris Müller +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1114
-
Jörg Bösche uploaded patch set 1 12/20/18, 11:07
-
TYPO3com voted on patch set 1 V -1 12/20/18, 11:26 Completed build in 17m 18s on Thu, 20 Dec, 12:26 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30939
-
Jörg Bösche uploaded patch set 2 12/20/18, 11:49
-
TYPO3com voted on patch set 2 V +1 12/20/18, 12:02 Completed build in 13m 03s on Thu, 20 Dec, 01:02 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30945
-
Benni Mack commented on patch set 2 12/20/18, 12:13
using __wakeup and __sleep is what we've used in ContentObjectRenderer for this case. Could you see if we can use the same logic here as well? -
Jörg Bösche uploaded patch set 3 12/20/18, 12:30
-
Benni Mack voted on patch set 3 V +1 CR +1 12/20/18, 12:35
-
Christian Kuhn voted on patch set 3 V +1 CR +1 12/20/18, 12:37
-
TYPO3com voted on patch set 3 V +1 12/20/18, 12:42 Completed build in 12m 24s on Thu, 20 Dec, 01:42 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30952
-
Chris Müller voted on patch set 3 V +1 CR +1 12/21/18, 07:19
-
Benni Mack voted on patch set 3 V +2 CR +2 12/21/18, 09:33
-
Benni Mack merged patch set 4 12/21/18, 09:33
-
Benni Mack commented on patch set 4 12/21/18, 09:33
Cherry Picked This patchset was cherry picked to branch 9.5 as commit 8cd9ff514fd7fbc65b8f1fbd69a4e35d59886750 -
Markus Klein commented on patch set 4 09/13/19, 20:11
AbstractTask.php:120UnresolvedThis is a major breaking change! Our scheduler tasks have protected members which are not persisted anymore. (these worked in v7)