Review main Merged

59256[BUGFIX] Show domains from Site configs in redirect picker

Benni Mack CR +2 V +2 Normal +56 −15 updated 12/21/18, 22:09

Commit message

The FormEngine sys_redirect value picker for "host" was built on
top of sys_domain, however the value picker should
include domains (hosts) from site configurations
as well.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1014

  1. Benni Mack uploaded patch set 1 12/21/18, 13:02

  2. Benni Mack uploaded patch set 2 12/21/18, 13:03

  3. Georg Ringer voted on patch set 2 CR +1 12/21/18, 13:05

  4. TYPO3com voted on patch set 1 V -1 12/21/18, 13:13 Completed build in 11m 13s on Fri, 21 Dec, 02:13 PM Test Summary: 1238 of 48613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31026

  5. TYPO3com voted on patch set 2 V -1 12/21/18, 13:15 Completed build in 11m 07s on Fri, 21 Dec, 02:15 PM Test Summary: 851 of 48613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31027

  6. Benni Mack updated the commit message in patch set 3 12/21/18, 18:59

  7. TYPO3com voted on patch set 3 V -1 12/21/18, 19:11 Completed build in 11m 48s on Fri, 21 Dec, 08:11 PM Test Summary: 1106 of 48587 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31036

  8. Benni Mack uploaded patch set 4 12/21/18, 19:20

  9. TYPO3com voted on patch set 4 V +1 12/21/18, 19:31 Completed build in 10m 43s on Fri, 21 Dec, 08:31 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31038

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 12/21/18, 19:44

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 12/21/18, 22:08

  12. Benni Mack voted on patch set 4 V +2 CR +2 12/21/18, 22:09

  13. Benni Mack merged patch set 5 12/21/18, 22:09

  14. Benni Mack commented on patch set 5 12/21/18, 22:09

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 030e10d882201884f550faa0012399299a989d8a