Review main Merged

59257[BUGFIX] Do not link to untranslated records

Mathias Brodala CR +2 V +2 Normal +44 −12 updated 12/27/21, 08:43

Commit message

This only fixes the issue for dedicated record links. Page links with
added query arguments can still lead to broken links.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2538

Show 813 earlier messages
  1. Mathias Brodala uploaded patch set 1 12/21/18, 13:57

  2. TYPO3com voted on patch set 1 V -1 12/21/18, 14:12 Completed build in 15m 01s on Fri, 21 Dec, 03:12 PM Test Summary: 837 of 48613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31028

  3. TYPO3com commented on patch set 1 04/29/19, 20:41 Completed build in 14m 23s on Mon, 29 Apr, 10:41 PM Test Summary: 2046 of 47861 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33660

  4. Susi Moog commented on patch set 1 04/29/19, 20:47

    DatabaseRecordLinkBuilder.php:58

    these should probably use the Context API now.
  5. TYPO3com voted on patch set 1 V +1 01/19/20, 09:11 Completed build in 13m 46s on Sun, 19 Jan, 09:11 AM Test Summary: 70442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40076

  6. Susi Moog uploaded patch set 2 01/25/20, 11:38

  7. Susi Moog voted on patch set 2 CR +1 01/25/20, 11:55

  8. TYPO3com voted on patch set 2 V -1 01/25/20, 11:56 Completed build in 14m 43s on Sat, 25 Jan, 11:56 AM Test Summary: 54 of 71032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40214

  9. Susi Moog uploaded patch set 3 01/25/20, 13:03

  10. TYPO3com voted on patch set 3 V +1 01/25/20, 13:15 Completed build in 11m 15s on Sat, 25 Jan, 01:15 PM Test Summary: 70582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40219

  11. Susi Moog voted on patch set 3 V +1 CR +1 01/25/20, 15:20

  12. Daniel Goerz commented on patch set 3 V -1 01/25/20, 16:46

    In master the translated links to the untranslated (extbase) records do not lead to 404 pages for me but to the default record, no special config AFAICS. With the patch applied the records are no longer linked which I would consider a bug if I'd rely on the current behavior.
  13. Susi Moog commented on patch set 3 V 0 CR 0 01/26/20, 07:43

    > Patch Set 3: Verified-1 > > In master the translated links to the untranslated (extbase) records do not lead to 404 pages for me but to the default record, no special config AFAICS. > > With the patch applied the records are no longer linked which I would consider a bug if I'd rely on the current behavior. Hmm, depends ;) My problem with the fallback is: having a link to a non-translated element now results in switching of the language context of the site if clicked - which is very unexpected from a users perspective - I'd rather not link elements at all then. But I agree that this depends on what you would expect. - v8 never switched the language context (always attached the L param even though that might result in broken links) - v10 content element links also keep the language context (and link / anchor to non-existing values if the element is not translated) - v10 page links result in 404s but keep the language context so basically, record links doing a fallback is kind of weird in comparison. They should either not link or keep the context.
  1. Markus Klein commented on patch set 3 03/27/20, 10:18

    See also #90850
  2. Benni Mack commented on patch set 3 06/04/20, 19:31

    DatabaseRecordLinkBuilder.php:55

    In general this is OK, but if we use the $tsfe->sys_page->getLanguageOverlay() method we don't have to fetch the context and aspect. What do you think?
  3. Mathias Brodala commented on patch set 3 01/07/21, 15:37

    DatabaseRecordLinkBuilder.php:55 Reply

    Sorry for the very late reply: this doesn't work unfortunately since getLanguageOverlay() will just return the original row without any additional hint. So we cannot determine if no overlay was found or the current row simply matches the current (default) language.
  4. Mathias Brodala uploaded patch set 4 01/07/21, 15:41

  5. Mathias Brodala uploaded patch set 5 01/07/21, 15:41

  6. TYPO3com voted on patch set 4 V -1 01/07/21, 15:52 Completed build in 10m 47s on Thu, 7 Jan, 03:52 PM Test Summary: 1814 of 31315 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8742

  7. TYPO3com voted on patch set 5 V -1 01/07/21, 15:54 Completed build in 12m 21s on Thu, 7 Jan, 03:54 PM Test Summary: 30763 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8743

  8. Mathias Brodala rebased onto patch set 6 02/05/21, 08:11

  9. TYPO3com voted on patch set 6 V -1 02/05/21, 08:30 Completed build in 13m 15s on Fri, 5 Feb, 08:30 AM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9280

  10. core-ci voted on patch set 6 V +1 02/05/21, 08:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/398

  11. Benni Mack updated the commit message in patch set 7 11/18/21, 10:37

  12. Mathias Brodala commented on patch set 7 11/18/21, 10:41

    DatabaseRecordLinkBuilder.php:58 Reply

    Done
  13. core-ci voted on patch set 7 V -1 11/18/21, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19447

  14. Benni Mack wrote 11/29/21, 10:16

    Change destination moved from master to main
  15. Benni Mack updated the commit message in patch set 8 11/29/21, 14:02

  16. core-ci voted on patch set 8 V -1 11/29/21, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20077

  17. Benni Mack uploaded patch set 9 12/22/21, 11:07

  18. core-ci voted on patch set 9 V +1 12/22/21, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21392

  19. Benni Mack uploaded patch set 10 12/23/21, 11:12

  20. Benni Mack commented on patch set 10 V +1 CR +1 12/23/21, 11:12

    DatabaseRecordLinkBuilder.php:55 Reply

    Done
  21. core-ci voted on patch set 10 V +1 12/23/21, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21419

  22. Jochen Roth voted on patch set 10 V +1 CR +1 12/23/21, 16:10

  23. Benni Mack voted on patch set 10 V +2 CR +2 12/23/21, 16:20

  24. Benni Mack merged patch set 11 12/23/21, 16:20

  25. Mathias Brodala commented on patch set 11 12/27/21, 08:43

    Thanks a lot for finishing this!