Review main Merged

59265[BUGFIX] Invalidate cached PageTitleProvider

Guido Schmechel CR +2 V +2 Easy +1 −1 updated 01/04/19, 19:54

Commit message

After handling/saving a page the cache entry for pageTitle
is removed, too.

Review

  • Code review CR +2
    • Georg Ringer +2
    • JarvisH +1
    • Richard Haeser +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Richard Haeser +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Guido Schmechel uploaded patch set 1 12/22/18, 11:29

  2. TYPO3com voted on patch set 1 V +1 12/22/18, 11:40 Completed build in 10m 43s on Sat, 22 Dec, 12:40 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31060

  3. Georg Ringer commented on patch set 1 CR -1 12/22/18, 11:42

    why not use the pageId tag for the title as well? I am pretty sure other developers will fail to identify this issue as well
  4. Guido Schmechel commented on patch set 1 12/22/18, 11:45

    https://review.typo3.org/c/58891/ Maybe Richard can say something about it?
  5. Guido Schmechel commented on patch set 1 12/22/18, 11:58

    My assumption: They wanted to get some flexibility in here, because title could well come in by other providers who might not necessarily have something to do with the page.
  6. Richard Haeser commented on patch set 1 12/22/18, 18:56

    > My assumption: They wanted to get some flexibility in here, because > title could well come in by other providers who might not > necessarily have something to do with the page. Well, to be honest there was no special reason for besides that it might be useful in the future. Meanwhile I did not have any reason why we can't use the pageId tag. I think, it might be better to fix it in the PageTitleProviderManager to set the right tag.
  7. Guido Schmechel uploaded patch set 2 12/22/18, 22:54

  8. TYPO3com voted on patch set 2 V +1 12/22/18, 23:04 Completed build in 10m 31s on Sun, 23 Dec, 12:04 AM Test Summary: 47813 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31118

  9. JarvisH voted on patch set 2 CR +1 01/04/19, 17:16

  10. Benni Mack voted on patch set 2 V +1 CR +1 01/04/19, 19:49

  11. Richard Haeser voted on patch set 2 V +1 CR +1 01/04/19, 19:50

  12. Georg Ringer voted on patch set 2 V +2 CR +2 01/04/19, 19:53

  13. Georg Ringer merged patch set 3 01/04/19, 19:53

  14. Georg Ringer commented on patch set 3 01/04/19, 19:54

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 40d0ba4ed7c4e544cc2e127bd4c30bb864f03235