Review main Merged

59266[BUGFIX] Add PATH_site to extension scanner

Christian Kuhn CR +2 V +2 Easy +5 −0 updated 12/22/18, 12:49

Commit message

When deprecating PATH_site constants we missed
an entry in the extension scanner. Let's add that
matcher since the constant is rather frequently
used in extensions and deserves a match.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
  • Verified V +2
    • Georg Ringer +2
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 12/22/18, 11:53

  2. Christian Kuhn updated the commit message in patch set 2 12/22/18, 11:54

  3. TYPO3com voted on patch set 1 V +1 12/22/18, 12:05 Completed build in 12m 30s on Sat, 22 Dec, 01:05 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31063

  4. TYPO3com voted on patch set 2 V +1 12/22/18, 12:05 Completed build in 11m 40s on Sat, 22 Dec, 01:05 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31064

  5. Alexander Schnitzler voted on patch set 2 V +1 CR +1 12/22/18, 12:27

  6. Oliver Klee voted on patch set 2 CR +1 12/22/18, 12:31

  7. Georg Ringer voted on patch set 2 V +2 CR +2 12/22/18, 12:49

  8. Georg Ringer merged patch set 3 12/22/18, 12:49

  9. Georg Ringer commented on patch set 3 12/22/18, 12:49

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 793976c26f3e84c2d667ae5bf07a3423afab52de