Review main Merged

59270[BUGFIX] Corrected tooltip for pages with nav_hide

Guido Schmechel CR +2 V +2 Easy +4 −1 updated 02/07/19, 05:12

Commit message

The inverted state of the nav_hide values is now considered.
For this purpose, the original label is supplemented again.

Review

  • Code review CR +2
    • Jan Helke +2
    • Stefanos Karasavvidis +1
  • Verified V +2
    • Jan Helke +2
    • Riccardo De Contardi +1
    • Stefanos Karasavvidis +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Guido Schmechel uploaded patch set 1 12/22/18, 12:24

  2. TYPO3com voted on patch set 1 V +1 12/22/18, 12:39 Completed build in 12m 02s on Sat, 22 Dec, 01:39 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31069

  3. Riccardo De Contardi voted on patch set 1 V +1 12/22/18, 15:39

  4. Stefanos Karasavvidis commented on patch set 1 V +1 01/09/19, 14:35

    I'd remove the call to rtrim

    BackendUtility.php:1326

    Is there any reason to continue calling the rtrim function with the text?
  5. Guido Schmechel uploaded patch set 2 01/10/19, 21:28

  6. Riccardo De Contardi voted on patch set 2 V +1 01/10/19, 21:32

  7. TYPO3com voted on patch set 2 V +1 01/10/19, 21:37 Completed build in 09m 11s on Thu, 10 Jan, 10:37 PM Test Summary: 47609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31407

  8. Stefanos Karasavvidis voted on patch set 2 V +1 CR +1 01/11/19, 07:26

  9. Jan Helke voted on patch set 2 V +2 CR +2 01/11/19, 08:26

  10. Jan Helke merged patch set 3 01/11/19, 08:26

  11. Josef Glatz commented on patch set 3 02/07/19, 05:09

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 2825bb159b978578bdb7955dd73882608b94f4e9
  12. Josef Glatz commented on patch set 3 02/07/19, 05:12

    @Jan Unfortunately did you forgot to cherry pick this one.