Review main Merged Breaking

59273[!!!][TASK] Remove deprecated Extbase-related code (Part 3)

Alexander Schnitzler CR +2 V +2 Normal +15 −145 updated 02/18/19, 14:12

Commit message

* public static method in ActionController
* public method in Argument
* public method in Arguments
* class AbstractValidatorTestcase
* legacy location of settings.view.formatToPageTypeMapping

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 79

  1. Alexander Schnitzler uploaded patch set 1 12/22/18, 13:16

  2. TYPO3com voted on patch set 1 V +1 12/22/18, 13:28 Completed build in 11m 32s on Sat, 22 Dec, 02:28 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31071

  3. Christian Kuhn uploaded patch set 2 12/22/18, 13:56

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 12/22/18, 13:57

  5. TYPO3com voted on patch set 2 V +1 12/22/18, 14:09 Completed build in 13m 03s on Sat, 22 Dec, 03:09 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31075

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 12/22/18, 14:20

  7. Anja Leichsenring merged patch set 3 12/22/18, 14:20

  8. Susi Moog commented on patch set 3 02/13/19, 14:08

    ExtensionService.php:242

    post -1 here - the mergeRecursive now merges nothing and introduces a bug...
  9. Alexander Schnitzler commented on patch set 3 02/18/19, 14:12

    ExtensionService.php:242 Reply

    Will be taken care of in this patch set: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59719