Review main Merged

59281[BUGFIX] Skip error when processing already deleted records

Christoph Lehmann CR +2 V +2 Easy +4 −0 updated 03/09/20, 11:25

Commit message

A record may be deleted already by an earlier call of deleteRecord()
which can occur by deleting records with tt_content IRRE elements
what is done by the gridelements extension.

This prevents the error "Attempt to delete record without delete-permissions"
which occurs in the second attempt where $hasEditAccess is false (as normal editor).

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1623

  1. Christoph Lehmann uploaded patch set 1 12/22/18, 16:48

  2. TYPO3com voted on patch set 1 V -1 12/22/18, 16:58 Completed build in 09m 49s on Sat, 22 Dec, 05:58 PM Test Summary: 744 of 48224 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31102

  3. Christoph Lehmann commented on patch set 2 12/22/18, 17:34

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 12/22/18, 17:49 Completed build in 14m 11s on Sat, 22 Dec, 06:49 PM Test Summary: 744 of 48224 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31107

  5. Christoph Lehmann uploaded patch set 3 12/22/18, 20:37

  6. TYPO3com voted on patch set 3 V +1 12/22/18, 20:47 Completed build in 10m 08s on Sat, 22 Dec, 09:47 PM Test Summary: 47813 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31117

  7. Mathias Brodala commented on patch set 3 01/07/19, 13:39

    DataHandler.php:5261

    This could be simplified: in_array($uid, $this->deletedRecords[$table] ?? [], true)
  8. Christoph Lehmann commented on patch set 4 01/07/19, 14:05

    Published edit on patch set 3.
  9. TYPO3com voted on patch set 4 V +1 01/07/19, 14:14 Completed build in 09m 15s on Mon, 7 Jan, 03:14 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31287

  10. Mathias Brodala updated the commit message in patch set 5 01/07/19, 14:14

  11. TYPO3com voted on patch set 5 V +1 01/07/19, 14:24 Completed build in 10m 00s on Mon, 7 Jan, 03:24 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31288

  12. Benni Mack uploaded patch set 6 11/09/19, 11:34

  13. TYPO3com voted on patch set 6 V +1 11/09/19, 11:55 Completed build in 14m 08s on Sat, 9 Nov, 11:55 AM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38156

  14. Steffen Frese voted on patch set 6 CR +1 01/17/20, 03:48

  15. Sascha Rademacher voted on patch set 6 CR +1 01/17/20, 09:31

  16. Henning Liebe voted on patch set 6 CR +1 01/17/20, 10:56

  17. Felix P. voted on patch set 6 CR +1 01/17/20, 12:38

  18. Tymoteusz Motylewski commented on patch set 6 01/17/20, 19:05

    DataHandler.php:4686 Unresolved

    Skip error? What error? Maybe „skip processing already deleted records”
  19. Benni Mack commented on patch set 7 03/07/20, 11:13

    Published edit on patch set 6.
  20. TYPO3com voted on patch set 7 V +1 03/07/20, 11:26 Completed build in 12m 48s on Sat, 7 Mar, 11:26 AM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1078

  21. Benni Mack voted on patch set 7 V +1 CR +1 03/09/20, 11:14

  22. Georg Ringer voted on patch set 7 V +2 CR +2 03/09/20, 11:25

  23. Georg Ringer merged patch set 8 03/09/20, 11:25