59290[BUGFIX] Install tool: Allow row updater as valid identifier
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Daniel Gorges +1
-
Verified V +2
- Benni Mack +2
- Daniel Gorges +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Thorben Nissen uploaded patch set 1 12/23/18, 21:17
-
TYPO3com voted on patch set 1 V +1 12/23/18, 21:28 Completed build in 11m 12s on Sun, 23 Dec, 10:28 PM Test Summary: 47813 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31129
-
Benni Mack commented on patch set 1 12/27/18, 20:33
can we use instanceof instead? -
Thorben Nissen commented on patch set 1 12/28/18, 17:50
@Benni As far as I know, `instanceof` does not support string on the left side. -
Andreas Kienast commented on patch set 1 12/29/18, 07:55
is_a($identifier, RowUpdaterInterface::class, true) could work -
Benni Mack voted on patch set 1 CR +1 12/30/18, 19:31
-
Daniel Gorges voted on patch set 1 V +1 CR +1 01/09/19, 13:06
-
Benni Mack voted on patch set 1 V +2 CR +2 01/09/19, 13:11
-
Benni Mack merged patch set 2 01/09/19, 13:11
-
Benni Mack commented on patch set 2 01/09/19, 13:11
Cherry Picked This patchset was cherry picked to branch 9.5 as commit efe632adf70c25b7167a0cfb6f1b53dd1354818d