59295[!!!][TASK] Remove deprecated code from EXT:install
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Andreas Kienast +1
-
Verified V +2
- Georg Ringer +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst+4 −0
- typo3/sysext/install/Classes/Controller/LayoutController.php+0 −59
- typo3/sysext/install/Classes/Controller/UpgradeController.php+2 −16
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+0 −28
- typo3/sysext/install/Classes/Service/CoreVersionService.php+0 −71
- typo3/sysext/install/Classes/Updates/AbstractUpdate.phpdeleted+0 −309
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+4 −0
- typo3/sysext/install/Resources/Public/JavaScript/Modules/Router.js+1 −28
- typo3/sysext/install/Tests/UnitDeprecated/Service/CoreVersionServiceTest.phpdeleted+0 −63
Review log 811
-
Wouter Wolters uploaded patch set 1 12/25/18, 12:09
-
TYPO3com voted on patch set 1 V -1 12/25/18, 12:20 Completed build in 11m 07s on Tue, 25 Dec, 01:20 PM Test Summary: 2 of 48224 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31135
-
Wouter Wolters uploaded patch set 2 12/25/18, 12:22
-
TYPO3com voted on patch set 2 V +1 12/25/18, 12:33 Completed build in 11m 09s on Tue, 25 Dec, 01:33 PM Test Summary: 47811 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31136
-
Andreas Kienast commented on patch set 2 CR -1 01/06/19, 14:40
on it -
Andreas Kienast uploaded patch set 3 01/06/19, 14:45
-
Andreas Kienast voted on patch set 3 V +1 CR +1 01/06/19, 14:48
-
TYPO3com voted on patch set 3 V +1 01/06/19, 14:57 Completed build in 11m 16s on Sun, 6 Jan, 03:57 PM Test Summary: 47687 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31250
-
Georg Ringer voted on patch set 3 V +2 CR +2 01/06/19, 19:21
-
Georg Ringer merged patch set 4 01/06/19, 19:21
-
Frank Nägler commented on patch set 4 10/11/19, 12:30
With this patch the AbstractUpdate class was removed but this is not mentioned in the RST file also the extension scanner does not find this. That's really bad because also extensions provide UpdateWizards.