Review main Merged

59304[FEATURE] Introduce events to modify CKEditor configuration

Benjamin Kott CR +2 V +2 Hard +342 −12 updated 02/19/20, 14:54

Commit message

This patch introduces a set of PSR-14 Events to modify
the CKEditor configuration.

- AfterGetExternalPluginsEvent
- BeforeGetExternalPluginsEvent
- AfterPrepareConfigurationForEditorEvent
- BeforePrepareConfigurationForEditorEvent

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1830

Show 35 earlier messages
  1. Benjamin Kott uploaded patch set 1 12/29/18, 11:04

  2. TYPO3com voted on patch set 1 V +1 12/29/18, 11:15 Completed build in 10m 44s on Sat, 29 Dec, 12:15 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31155

  3. Frank Nägler uploaded patch set 2 01/17/20, 10:40

  4. TYPO3com voted on patch set 2 V +1 01/17/20, 10:50 Completed build in 10m 10s on Fri, 17 Jan, 10:50 AM Test Summary: 70442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40061

  5. Benjamin Kott uploaded patch set 3 01/18/20, 15:57

  1. TYPO3com voted on patch set 3 V -1 01/18/20, 16:07 Completed build in 09m 22s on Sat, 18 Jan, 04:07 PM Test Summary: 1 of 70589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40069

  2. Benjamin Kott uploaded patch set 4 01/18/20, 16:42

  3. TYPO3com voted on patch set 4 V -1 01/18/20, 16:52 Completed build in 10m 14s on Sat, 18 Jan, 04:52 PM Test Summary: 70435 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40071

  4. TYPO3com voted on patch set 4 V +1 01/18/20, 16:55 Completed build in 23m 40s on Sat, 18 Jan, 04:55 PM Test Summary: 70442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40071

  5. Benni Mack commented on patch set 4 01/20/20, 07:38

    Event classes are named ...Event.
  6. Benjamin Kott uploaded patch set 5 01/20/20, 09:26

  7. Benjamin Kott commented on patch set 5 01/20/20, 09:31

  8. Benjamin Kott uploaded patch set 6 01/20/20, 09:39

  9. Benjamin Kott voted on patch set 6 CR -1 01/20/20, 09:39

  10. TYPO3com voted on patch set 5 V +1 01/20/20, 09:43 Completed build in 13m 07s on Mon, 20 Jan, 09:43 AM Test Summary: 70490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40105

  11. TYPO3com voted on patch set 6 V +1 01/20/20, 09:49 Completed build in 09m 53s on Mon, 20 Jan, 09:49 AM Test Summary: 70490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40106

  12. Benjamin Kott uploaded patch set 7 01/20/20, 09:57

  13. Benjamin Kott uploaded patch set 8 01/20/20, 10:01

  14. TYPO3com voted on patch set 7 V -1 01/20/20, 10:07 Completed build in 10m 16s on Mon, 20 Jan, 10:07 AM Test Summary: 70489 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40107

  15. TYPO3com voted on patch set 8 V +1 01/20/20, 10:12 Completed build in 10m 35s on Mon, 20 Jan, 10:12 AM Test Summary: 70490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40108

  16. Benjamin Kott uploaded patch set 9 01/20/20, 12:03

  17. Benjamin Kott uploaded patch set 10 01/20/20, 12:04

  18. TYPO3com voted on patch set 9 V +1 01/20/20, 12:14 Completed build in 11m 08s on Mon, 20 Jan, 12:14 PM Test Summary: 70491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40113

  19. TYPO3com voted on patch set 10 V +1 01/20/20, 12:19 Completed build in 13m 41s on Mon, 20 Jan, 12:19 PM Test Summary: 70493 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40114

  20. Benjamin Kott commented on patch set 10 CR -1 01/20/20, 12:45

    Not sure if events also need to get the current data assigned, so that a context can be build? Example: User edits a record for a site, user should get a editor css file specific for that site.
  21. Benjamin Kott uploaded patch set 11 02/14/20, 14:30

  22. TYPO3com voted on patch set 11 V +1 02/14/20, 14:43 Completed build in 13m 04s on Fri, 14 Feb, 02:43 PM Test Summary: 71242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-79

  23. Georg Ringer voted on patch set 11 V +1 CR +1 02/19/20, 14:12

  24. Benni Mack voted on patch set 11 V +2 CR +2 02/19/20, 14:54

  25. Benni Mack merged patch set 12 02/19/20, 14:54