Review main Abandoned

59308[WIP][TASK] Add functional tests for testing class overriding

Alexander Schnitzler CR 0 V 0 Hard +335 −0 updated 02/04/19, 08:52

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 17

Review log 1115

  1. Alexander Schnitzler uploaded patch set 1 12/30/18, 14:46

  2. Alexander Schnitzler voted on patch set 1 V -1 12/30/18, 14:47

  3. TYPO3com voted on patch set 1 V -1 12/30/18, 14:58 Completed build in 10m 58s on Sun, 30 Dec, 03:58 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31169

  4. Alexander Schnitzler uploaded patch set 2 12/30/18, 15:01

  5. Alexander Schnitzler voted on patch set 2 V -1 12/30/18, 15:01

  6. TYPO3com voted on patch set 2 V +1 12/30/18, 15:10 Completed build in 09m 27s on Sun, 30 Dec, 04:10 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31171

  7. Alexander Schnitzler uploaded patch set 3 12/30/18, 15:39

  8. Alexander Schnitzler voted on patch set 3 V -1 12/30/18, 15:39

  9. TYPO3com voted on patch set 3 V +1 12/30/18, 15:49 Completed build in 09m 58s on Sun, 30 Dec, 04:49 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31174

  10. Markus Klösges commented on patch set 3 01/03/19, 12:43

    > Patch Set 3: Verified+1 I can confirm, that Build/Scripts/runTests.sh locally shows (correctly), that testARepositoryObjectsAreTakenFromSession *fails* with the current code. No clue why that is not the case on bamboo.
  11. Markus Klösges voted on patch set 3 V -1 01/03/19, 12:43

  12. Markus Klösges uploaded patch set 4 01/03/19, 13:35

  13. Markus Klösges commented on patch set 4 01/03/19, 13:43

    the script that splits functional tests into batches for parallel execution on bamboo only fetches tests with @test annotations. Therefore the new tests here were not picked up, when running the tests on bamboo.
  14. TYPO3com voted on patch set 4 V -1 01/03/19, 13:46 Completed build in 10m 26s on Thu, 3 Jan, 02:46 PM Test Summary: 3 of 48250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31190

  15. Alexander Schnitzler abandoned the change 02/04/19, 08:52

    Tests have been used in another patch set and are merged into core.