59331[TASK] Avoid runtime reflection calls in ObjectAccess
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- André Buchmann +1
-
Verified V +2
- Andreas Wolf +2
- André Buchmann +1
Issues 1
Files 15
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-87332-AvoidRuntimeReflectionCallsInObjectAccess.rst2new+40 −0
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php+3 −4
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+204 −145
- typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php1+9 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+2 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+5 −67
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+10 −0
- typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/ObjectAccessTest.phpnew+95 −0
- typo3/sysext/extbase/composer.json+1 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedStaticMatcher.php+18 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- composer.json+1 −0
- composer.lock+68 −1
Review log 4772
Show 2947 earlier messages
-
Alexander Schnitzler uploaded patch set 1 01/04/19, 19:25
-
Alexander Schnitzler voted on patch set 1 CR -1 01/04/19, 19:25
-
Alexander Schnitzler updated the commit message in patch set 2 01/04/19, 19:26
-
Alexander Schnitzler voted on patch set 2 CR -1 01/04/19, 19:26
-
TYPO3com voted on patch set 2 V +1 01/04/19, 20:15 Completed build in 22m 18s on Fri, 4 Jan, 09:15 PM Test Summary: 47815 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31211
-
Alexander Schnitzler uploaded patch set 3 01/04/19, 20:17
-
TYPO3com voted on patch set 3 V -1 01/04/19, 21:06 Completed build in 45m 51s on Fri, 4 Jan, 10:06 PM Test Summary: 47737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31215
-
TYPO3com voted on patch set 3 V +1 01/04/19, 21:08 Completed build in 1h 34m 01s on Fri, 4 Jan, 10:08 PM Test Summary: 47809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31215
-
Alexander Schnitzler voted on patch set 3 CR -1 01/04/19, 21:22
-
TYPO3com commented on patch set 2 01/04/19, 21:36 Completed build in 5h 22m 36s on Fri, 4 Jan, 10:36 PM Test Summary: 47829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31207
-
TYPO3com voted on patch set 1 V +1 01/04/19, 21:36 Completed build in 2h 09m 13s on Fri, 4 Jan, 10:36 PM Test Summary: 47829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31206
-
Alexander Schnitzler uploaded patch set 4 01/04/19, 21:51
-
Alexander Schnitzler voted on patch set 4 CR -1 01/04/19, 21:52
-
Alexander Schnitzler uploaded patch set 5 01/04/19, 22:19
-
TYPO3com voted on patch set 5 V -1 01/04/19, 22:48 Completed build in 29m 09s on Fri, 4 Jan, 11:48 PM Test Summary: 47429 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31219
-
TYPO3com voted on patch set 4 V -1 01/04/19, 22:50 Completed build in 58m 10s on Fri, 4 Jan, 11:50 PM Test Summary: 4 of 48178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31218
-
Alexander Schnitzler uploaded patch set 6 01/05/19, 09:38
-
TYPO3com voted on patch set 6 V -1 01/05/19, 09:48 Completed build in 10m 10s on Sat, 5 Jan, 10:48 AM Test Summary: 47500 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31221
-
TYPO3com voted on patch set 6 V +1 01/05/19, 09:57 Completed build in 29m 33s on Sat, 5 Jan, 10:57 AM Test Summary: 47767 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31221
-
Oliver Klee updated the commit message in patch set 7 01/05/19, 12:56
-
TYPO3com voted on patch set 7 V +1 01/05/19, 13:11 Completed build in 14m 22s on Sat, 5 Jan, 02:11 PM Test Summary: 47767 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31224
-
Alexander Schnitzler uploaded patch set 8 01/08/19, 10:05
-
TYPO3com voted on patch set 8 V -1 01/08/19, 10:16 Completed build in 10m 31s on Tue, 8 Jan, 11:16 AM Test Summary: 8 of 47716 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31329
-
Alexander Schnitzler uploaded patch set 9 01/08/19, 10:25
-
TYPO3com voted on patch set 9 V +1 01/08/19, 10:34 Completed build in 09m 28s on Tue, 8 Jan, 11:34 AM Test Summary: 47323 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31331
-
Alexander Schnitzler wrote 01/09/19, 13:43
Topic set to extbase -
Andreas Kienast uploaded patch set 10 01/09/19, 18:28
-
TYPO3com voted on patch set 10 V +1 01/09/19, 18:37 Completed build in 09m 11s on Wed, 9 Jan, 07:37 PM Test Summary: 47607 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31380
-
Alexander Schnitzler uploaded patch set 11 01/12/19, 13:25
-
TYPO3com voted on patch set 11 V +1 01/12/19, 13:36 Completed build in 10m 38s on Sat, 12 Jan, 02:36 PM Test Summary: 47621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31468
-
Benni Mack commented on patch set 11 01/12/19, 20:31
Deprecation-87332-AvoidRuntimeReflectionCallsInObjectAccess.rst:4this is more a breaking change than a deprecation IMHO (which is fine) -
Alexander Schnitzler commented on patch set 11 01/15/19, 14:45
Deprecation-87332-AvoidRuntimeReflectionCallsInObjectAccess.rst:4ReplyWhy do you think so? The api remains the same. -
Alexander Schnitzler uploaded patch set 12 01/23/19, 14:14
-
TYPO3com voted on patch set 12 V +1 01/23/19, 14:29 Completed build in 15m 06s on Wed, 23 Jan, 03:29 PM Test Summary: 46892 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31731
-
Anja Leichsenring commented on patch set 12 01/28/19, 20:39
deprecation removal can only happen in v11. -
Alexander Schnitzler uploaded patch set 13 01/29/19, 12:55
-
TYPO3com voted on patch set 13 V +1 01/29/19, 13:07 Completed build in 11m 50s on Tue, 29 Jan, 02:07 PM Test Summary: 46880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31812
-
Anja Leichsenring voted on patch set 13 V +1 CR +1 01/29/19, 19:40
-
Andreas Wolf voted on patch set 13 CR +2 02/01/19, 09:09
-
Andreas Wolf uploaded patch set 14 02/01/19, 09:41
-
TYPO3com voted on patch set 14 V -1 02/01/19, 09:41 Completed build in 05s on Fri, 1 Feb, 10:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31875
-
Andreas Wolf voted on patch set 14 V +2 CR +2 02/01/19, 09:42
-
Andreas Wolf voted on patch set 14 V 0 CR 0 02/01/19, 09:44
-
Andreas Wolf commented on patch set 14 02/01/19, 09:44
on it -
Andreas Wolf uploaded patch set 15 02/01/19, 09:45
-
TYPO3com voted on patch set 15 V +1 02/01/19, 09:57 Completed build in 11m 57s on Fri, 1 Feb, 10:57 AM Test Summary: 46926 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31876
-
Alexander Schnitzler commented on patch set 15 02/01/19, 10:06
Thanks for the rebase!
-
Andreas Wolf commented on patch set 15 V +1 CR +1 02/01/19, 12:00
you're welcome :) -
Andreas Wolf uploaded patch set 16 02/01/19, 16:23
-
TYPO3com voted on patch set 16 V -1 02/01/19, 16:24 Completed build in 14s on Fri, 1 Feb, 05:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31933
-
Andreas Wolf uploaded patch set 17 02/01/19, 16:27
-
TYPO3com voted on patch set 17 V -1 02/01/19, 16:46 Completed build in 18m 49s on Fri, 1 Feb, 05:46 PM Test Summary: 551 of 46722 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31934
-
Anja Leichsenring uploaded patch set 18 02/01/19, 17:37
-
TYPO3com voted on patch set 18 V -1 02/01/19, 18:04 Completed build in 15m 03s on Fri, 1 Feb, 07:04 PM Test Summary: 1 of 46726 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31946
-
Anja Leichsenring rebased onto patch set 19 02/01/19, 18:08
-
TYPO3com voted on patch set 19 V +1 02/01/19, 18:22 Completed build in 13m 46s on Fri, 1 Feb, 07:22 PM Test Summary: 46369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31951
-
Anja Leichsenring voted on patch set 19 V +1 CR +1 02/01/19, 19:17
-
André Buchmann voted on patch set 19 V +1 CR +1 02/01/19, 20:20
-
Alexander Schnitzler uploaded patch set 20 02/02/19, 14:36
-
Alexander Schnitzler commented on patch set 20 02/02/19, 14:36
Just rebased the patch, pls re-vote. -
TYPO3com voted on patch set 20 V +1 02/02/19, 14:51 Completed build in 11m 49s on Sat, 2 Feb, 03:51 PM Test Summary: 46383 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31985
-
André Buchmann voted on patch set 20 V +1 CR +1 02/04/19, 14:59
-
Andreas Wolf commented on patch set 20 CR -1 02/05/19, 16:54
Author information somehow got lost during a rebase. I'm on it, please do not merge! -
Andreas Wolf uploaded patch set 21 02/05/19, 17:10
-
Andreas Wolf rebased onto patch set 22 02/05/19, 17:11
-
Andreas Wolf voted on patch set 22 V +1 CR +1 02/05/19, 17:12
-
André Buchmann voted on patch set 22 V +1 CR +1 02/05/19, 17:16
-
Andreas Wolf voted on patch set 22 V +2 CR +2 02/05/19, 17:16
-
Andreas Wolf merged patch set 23 02/05/19, 17:16
-
TYPO3com voted on patch set 21 V +1 02/05/19, 17:28 Completed build in 17m 35s on Tue, 5 Feb, 06:28 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32062
-
TYPO3com voted on patch set 22 V +1 02/05/19, 17:29 Completed build in 17m 45s on Tue, 5 Feb, 06:29 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32063
-
Markus Klein commented on patch set 23 06/29/20, 20:19
GenericObjectValidator.php:70UnresolvedThis is a breaking change if you have a model with a non-persisted class member with no setter/getter or whatsover (but other methods modifying the member).