Review main Merged

59343[BUGFIX] Set controller in ExtbasePluginEnhancer

Guido Schmechel CR +2 V +2 Easy +7 −0 updated 02/07/19, 12:08

Commit message

If the controller of a route in a routeEnhancer differs
from the default controller, it will now be used for the
generation of enhancers.

Review

  • Code review CR +2
    • Benni Mack +2
    • Alexander Grein +1
    • Richard Haeser +1
  • Verified V +2
    • Benni Mack +2
    • Alexander Grein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1213

  1. Guido Schmechel uploaded patch set 1 01/05/19, 18:35

  2. Guido Schmechel commented on patch set 1 01/05/19, 18:36

    See the current config/example in the issue.
  3. TYPO3com voted on patch set 1 V +1 01/05/19, 18:46 Completed build in 10m 36s on Sat, 5 Jan, 07:46 PM Test Summary: 47785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31233

  4. Oliver Klee commented on patch set 1 01/06/19, 13:28

    Can we cover this with tests to make sure this works correctly and will not break from future changes?
  5. Guido Schmechel commented on patch set 1 01/06/19, 17:28

    Basically, I have nothing against tests. But in this case, the entire class has no test coverage yet. Rather, I would look forward to a look from Oliver Hader, who is probably well versed in the subject. I notice in the examples, that only the news extension is assumed. Maybe I also have a misconfiguration here. If so, I would do that to prevent this from happening.
  6. Alexander Grein voted on patch set 1 V +1 CR +1 02/02/19, 21:53

  7. Richard Haeser voted on patch set 1 CR +1 02/03/19, 13:10

  8. Benni Mack voted on patch set 1 V +2 CR +2 02/07/19, 06:39

  9. Benni Mack merged patch set 2 02/07/19, 06:39

  10. Benni Mack commented on patch set 2 02/07/19, 06:39

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 16bb7a82fde158a7dbe4bc3d1edca331a4dbd629
  11. Oliver Hader commented on patch set 2 02/07/19, 07:51

    Post -1 Given that `_controller` is not mandatory, the following sequence has side effects: * 1: `defaultController` * 2: `_controller` * 3: `defaultController` Sequence index 3 will re-use `_controller` of index 2
  12. Benni Mack wrote 02/07/19, 08:28

    Created a revert of this change as I7167b42cb26538e676256c9d2e36d1ec18f2bd40
  13. Oliver Hader commented on patch set 2 02/07/19, 12:08