Review main Merged

59356[BUGFIX] Use `addOrderBy()` to support multiple orderings

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 01/08/19, 19:44

Commit message

`DatabaseRecordList::prepareQueryBuilder()` is able to handle multiple
order clauses defined in either `sortby` or `default_sortby`. However,
the wrong method for appending the order clause is used, which results in
overriding the previous set clause.

This patch changes the method to use `addOrderBy()` instead which appends
multiple order clauses properly.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Dorndorf +1
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Daniel Dorndorf +1
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 01/07/19, 14:26

  2. TYPO3com voted on patch set 1 V +1 01/07/19, 14:36 Completed build in 09m 57s on Mon, 7 Jan, 03:36 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31289

  3. Benni Mack commented on patch set 1 CR -1 01/07/19, 14:44

    has to be done in AbstractDatabaseRecordList, PageLayoutView and DatabaseRecordList for v9.5.
  4. Andreas Kienast commented on patch set 1 01/07/19, 14:45

    > has to be done in AbstractDatabaseRecordList, PageLayoutView and > DatabaseRecordList for v9.5. So, better do a manual backport right now?
  5. Andreas Kienast uploaded patch set 2 01/07/19, 15:15

  6. TYPO3com voted on patch set 2 V +1 01/07/19, 15:30 Completed build in 13m 37s on Mon, 7 Jan, 04:30 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31293

  7. Daniel Dorndorf voted on patch set 2 V +1 CR +1 01/07/19, 18:01

  8. Wouter Wolters voted on patch set 2 V +1 CR +1 01/08/19, 19:28

  9. Georg Ringer voted on patch set 2 V +2 CR +2 01/08/19, 19:44

  10. Georg Ringer merged patch set 3 01/08/19, 19:44