Review 9.5 Merged

59358[BUGFIX] Use `addOrderBy()` to support multiple orderings

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 01/09/19, 07:25

Commit message

`DatabaseRecordList::prepareQueryBuilder()` is able to handle multiple
order clauses defined in either `sortby` or `default_sortby`. However,
the wrong method for appending the order clause is used, which results in
overriding the previous set clause.

This patch changes the method to use `addOrderBy()` instead which appends
multiple order clauses properly.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Andreas Kienast uploaded patch set 1 01/07/19, 15:15

  2. TYPO3com voted on patch set 1 V +1 01/07/19, 15:28 Completed build in 13m 39s on Mon, 7 Jan, 04:28 PM Test Summary: 48785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-83

  3. Georg Ringer uploaded patch set 2 01/08/19, 19:45

  4. TYPO3com voted on patch set 2 V +1 01/08/19, 19:58 Completed build in 13m 15s on Tue, 8 Jan, 08:58 PM Test Summary: 49073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-91

  5. Andreas Kienast commented on patch set 2 CR -1 01/08/19, 20:00

    You've overridden the backport
  6. Andreas Kienast uploaded patch set 3 01/08/19, 21:09

  7. TYPO3com voted on patch set 3 V +1 01/08/19, 21:20 Completed build in 11m 07s on Tue, 8 Jan, 10:20 PM Test Summary: 49073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-93

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 01/08/19, 21:53

  9. Georg Ringer voted on patch set 3 V +2 CR +2 01/09/19, 07:25

  10. Georg Ringer merged patch set 4 01/09/19, 07:25