59362[TASK] Remove no_cache=1 from preview url generation
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 79
-
Georg Ringer uploaded patch set 1 01/07/19, 18:51
-
TYPO3com voted on patch set 1 V +1 01/07/19, 19:03 Completed build in 11m 27s on Mon, 7 Jan, 08:03 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31302
-
Benni Mack voted on patch set 1 V +1 CR +1 01/07/19, 19:27
-
Christian Kuhn commented on patch set 1 CR -1 01/07/19, 20:31
i don't think simply removing this argument is a good idea without further elaboration: if i call 'view' from within the backend i really never want a cached fe page displayed. the no_cache enforces that here. if we're sure that a fe request called from within the be is not cached, then please explain that in the commit message in a bit more detail on why no_cache is obsolete. -
Benni Mack uploaded patch set 2 06/05/19, 10:08
-
TYPO3com voted on patch set 2 V +1 06/05/19, 10:22 Completed build in 13m 31s on Wed, 5 Jun, 12:22 PM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34192
-
Benni Mack voted on patch set 2 V +1 CR +1 06/05/19, 10:58
-
Benjamin Franzke voted on patch set 2 V +2 CR +2 06/06/19, 08:10
-
Benjamin Franzke merged patch set 3 06/06/19, 08:10