Review main Merged

59362[TASK] Remove no_cache=1 from preview url generation

Georg Ringer CR +2 V +2 Easy +0 −1 updated 06/06/19, 08:10

Commit message

The usage of no_cache should be avoided. If still required it can be added
by using the setting additionalGetParameters.

As the functionality goes into the PageRouter (effectively adds cHash),
and it's possible that "no_cache" is completely disabled, it is not
necessary to be set. This was not the case in v9 as Site Handling
was not available everywhere.

On top, if an editor is actually previewing the content on the page
(via EditDocumentController "save + view") DataHandler is actually
flushing the cache of the page/record associated
(e.g. cacheTags for records), which is much more recommended.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 01/07/19, 18:51

  2. TYPO3com voted on patch set 1 V +1 01/07/19, 19:03 Completed build in 11m 27s on Mon, 7 Jan, 08:03 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31302

  3. Benni Mack voted on patch set 1 V +1 CR +1 01/07/19, 19:27

  4. Christian Kuhn commented on patch set 1 CR -1 01/07/19, 20:31

    i don't think simply removing this argument is a good idea without further elaboration: if i call 'view' from within the backend i really never want a cached fe page displayed. the no_cache enforces that here. if we're sure that a fe request called from within the be is not cached, then please explain that in the commit message in a bit more detail on why no_cache is obsolete.
  5. Benni Mack uploaded patch set 2 06/05/19, 10:08

  6. TYPO3com voted on patch set 2 V +1 06/05/19, 10:22 Completed build in 13m 31s on Wed, 5 Jun, 12:22 PM Test Summary: 46490 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34192

  7. Benni Mack voted on patch set 2 V +1 CR +1 06/05/19, 10:58

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 06/06/19, 08:10

  9. Benjamin Franzke merged patch set 3 06/06/19, 08:10