Review main Merged

59363[TASK] Raise typo3/testing-framework to ~5.0.1

Christian Kuhn CR +2 V +2 Easy +16 −24 updated 01/07/19, 20:35

Commit message

The new version no longer uses two deprecated frontend
hooks and switches to proper psr-15 middleware instead.
This unlocks the according hook removal for core in
a separate patch.

composer require --dev typo3/testing-framework ~5.0.1

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +2
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/07/19, 19:52

  2. TYPO3com voted on patch set 1 V +1 01/07/19, 20:06 Completed build in 14m 32s on Mon, 7 Jan, 09:06 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31304

  3. Christian Kuhn uploaded patch set 2 01/07/19, 20:20

  4. Benni Mack voted on patch set 2 V +2 CR +2 01/07/19, 20:21

  5. TYPO3com voted on patch set 2 V +1 01/07/19, 20:34 Completed build in 13m 54s on Mon, 7 Jan, 09:34 PM Test Summary: 47691 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31305

  6. Wouter Wolters voted on patch set 2 V +2 CR +2 01/07/19, 20:35

  7. Wouter Wolters merged patch set 3 01/07/19, 20:35