Review main Merged

59374[BUGFIX] Avoid fatal when flushed directory is a symlink

Helmut Hummel CR +2 V +2 Easy +6 −1 updated 01/09/19, 15:28

Commit message

\TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory tries to
rename the given directory to be able to atomically flush the
contents of the directory. This however fails, when the given
folder is a symlink.

We now catch this case by checking whether the given directory
is a symlink and resolve it with realpath.

While this does not cover all possible cases, it improves the
case where the folder containing the symlink is also writable.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Christian Kuhn +1
    • Fabien Udriot +1
  • Verified V +2
    • Mathias Brodala +2
    • Christian Kuhn +1
    • Fabien Udriot +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 813

  1. Helmut Hummel uploaded patch set 1 01/08/19, 14:36

  2. TYPO3com voted on patch set 1 V -1 01/08/19, 14:45 Completed build in 08m 49s on Tue, 8 Jan, 03:45 PM Test Summary: 45773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31339

  3. TYPO3com commented on patch set 1 01/08/19, 15:16 Completed build in 48m 20s on Tue, 8 Jan, 04:16 PM Test Summary: 45773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31339

  4. TYPO3com commented on patch set 1 01/08/19, 15:21 Completed build in 1h 32m 26s on Tue, 8 Jan, 04:21 PM Test Summary: 45773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31339

  5. TYPO3com commented on patch set 1 01/08/19, 15:32 Completed build in 2h 28m 13s on Tue, 8 Jan, 04:32 PM Test Summary: 45773 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31339

  6. Georg Ringer rebased onto patch set 2 01/08/19, 19:45

  7. TYPO3com voted on patch set 2 V +1 01/08/19, 19:58 Completed build in 13m 02s on Tue, 8 Jan, 08:58 PM Test Summary: 47629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31345

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 01/09/19, 14:14

  9. Fabien Udriot voted on patch set 2 V +1 CR +1 01/09/19, 14:34

  10. Mathias Brodala voted on patch set 2 V +2 CR +2 01/09/19, 15:28

  11. Mathias Brodala merged patch set 3 01/09/19, 15:28

  12. Mathias Brodala commented on patch set 3 01/09/19, 15:28

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit eb800952dde9236e4041386532091a26af359ee7
  13. Mathias Brodala commented on patch set 3 01/09/19, 15:28

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 057df0f7510a92cc4ba8f5caf8e10ac065e01441