59382[FEATURE] Improve ClassSchema properties api
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Anja Leichsenring +1
-
Verified V +2
- Benni Mack +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/core/Documentation/Changelog/master/Feature-86964-AllowGettingClassPropertyDefaultValue.rst+1 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+16 −8
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+32 −25
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+4 −4
- typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php+2 −2
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Exception/NoSuchPropertyException.phpnew+23 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Property.php1new+141 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+35 −12
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+12 −13
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+21 −29
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+7 −4
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/PropertyTest.phpnew+174 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −137
Review log 2028
Show 3 earlier messages
-
Alexander Schnitzler uploaded patch set 2 01/09/19, 11:46
-
TYPO3com voted on patch set 2 V -1 01/09/19, 11:46 Completed build in 10s on Wed, 9 Jan, 12:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31357
-
Alexander Schnitzler voted on patch set 2 CR -1 01/09/19, 11:46
-
TYPO3com voted on patch set 1 V -1 01/09/19, 11:49 Completed build in 09m 03s on Wed, 9 Jan, 12:49 PM Test Summary: 1111 of 48022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31356
-
Alexander Schnitzler uploaded patch set 3 01/09/19, 12:04
-
Alexander Schnitzler voted on patch set 3 CR -1 01/09/19, 12:04
-
TYPO3com voted on patch set 3 V -1 01/09/19, 12:14 Completed build in 10m 13s on Wed, 9 Jan, 01:14 PM Test Summary: 1039 of 48022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31358
-
Alexander Schnitzler uploaded patch set 4 01/09/19, 12:52
-
Alexander Schnitzler voted on patch set 4 CR -1 01/09/19, 12:52
-
TYPO3com voted on patch set 4 V +1 01/09/19, 13:01 Completed build in 09m 00s on Wed, 9 Jan, 02:01 PM Test Summary: 47629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31360
-
Alexander Schnitzler uploaded patch set 5 01/09/19, 13:30
-
TYPO3com voted on patch set 5 V +1 01/09/19, 13:42 Completed build in 11m 22s on Wed, 9 Jan, 02:42 PM Test Summary: 47629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31365
-
Anja Leichsenring commented on patch set 5 CR -1 01/11/19, 14:36
feature.rst missing. -
Anja Leichsenring commented on patch set 5 V +1 CR +1 01/11/19, 15:05
I accept no documentation, because the class schema component is internal. -
Alexander Schnitzler commented on patch set 5 CR -1 01/11/19, 15:44
Property.php:9Let's mark this class also internal for now. -
Alexander Schnitzler uploaded patch set 6 01/11/19, 15:46
-
TYPO3com voted on patch set 6 V +1 01/11/19, 16:01 Completed build in 11m 48s on Fri, 11 Jan, 05:01 PM Test Summary: 47641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31446
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 01/11/19, 16:17
-
Alexander Schnitzler uploaded patch set 7 01/11/19, 17:02
-
TYPO3com voted on patch set 7 V +1 01/11/19, 17:15 Completed build in 12m 33s on Fri, 11 Jan, 06:15 PM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31452
-
Alexander Schnitzler uploaded patch set 8 01/11/19, 17:21
-
TYPO3com voted on patch set 8 V +1 01/11/19, 17:31 Completed build in 10m 02s on Fri, 11 Jan, 06:31 PM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31454
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 01/11/19, 19:17
-
Benni Mack voted on patch set 8 V +2 CR +2 01/12/19, 20:30
-
Benni Mack merged patch set 9 01/12/19, 20:30