Review main Merged

59382[FEATURE] Improve ClassSchema properties api

Alexander Schnitzler CR +2 V +2 Hard +470 −236 updated 01/12/19, 20:30

Commit message

This patch introduces a new Property class to have an
easier and more stable api to get information about class
properties from ClassSchema objects

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Property objects are returned for the following calls:

- getProperty
- getProperties

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 2028

Show 3 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 01/09/19, 11:40

  2. Alexander Schnitzler wrote 01/09/19, 11:41

    Topic set to extbase
  3. Alexander Schnitzler voted on patch set 1 CR -1 01/09/19, 11:41

  1. Alexander Schnitzler uploaded patch set 2 01/09/19, 11:46

  2. TYPO3com voted on patch set 2 V -1 01/09/19, 11:46 Completed build in 10s on Wed, 9 Jan, 12:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31357

  3. Alexander Schnitzler voted on patch set 2 CR -1 01/09/19, 11:46

  4. TYPO3com voted on patch set 1 V -1 01/09/19, 11:49 Completed build in 09m 03s on Wed, 9 Jan, 12:49 PM Test Summary: 1111 of 48022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31356

  5. Alexander Schnitzler uploaded patch set 3 01/09/19, 12:04

  6. Alexander Schnitzler voted on patch set 3 CR -1 01/09/19, 12:04

  7. TYPO3com voted on patch set 3 V -1 01/09/19, 12:14 Completed build in 10m 13s on Wed, 9 Jan, 01:14 PM Test Summary: 1039 of 48022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31358

  8. Alexander Schnitzler uploaded patch set 4 01/09/19, 12:52

  9. Alexander Schnitzler voted on patch set 4 CR -1 01/09/19, 12:52

  10. TYPO3com voted on patch set 4 V +1 01/09/19, 13:01 Completed build in 09m 00s on Wed, 9 Jan, 02:01 PM Test Summary: 47629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31360

  11. Alexander Schnitzler uploaded patch set 5 01/09/19, 13:30

  12. TYPO3com voted on patch set 5 V +1 01/09/19, 13:42 Completed build in 11m 22s on Wed, 9 Jan, 02:42 PM Test Summary: 47629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31365

  13. Anja Leichsenring commented on patch set 5 CR -1 01/11/19, 14:36

    feature.rst missing.
  14. Anja Leichsenring commented on patch set 5 V +1 CR +1 01/11/19, 15:05

    I accept no documentation, because the class schema component is internal.
  15. Alexander Schnitzler commented on patch set 5 CR -1 01/11/19, 15:44

    Property.php:9

    Let's mark this class also internal for now.
  16. Alexander Schnitzler uploaded patch set 6 01/11/19, 15:46

  17. TYPO3com voted on patch set 6 V +1 01/11/19, 16:01 Completed build in 11m 48s on Fri, 11 Jan, 05:01 PM Test Summary: 47641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31446

  18. Anja Leichsenring voted on patch set 6 V +1 CR +1 01/11/19, 16:17

  19. Alexander Schnitzler uploaded patch set 7 01/11/19, 17:02

  20. TYPO3com voted on patch set 7 V +1 01/11/19, 17:15 Completed build in 12m 33s on Fri, 11 Jan, 06:15 PM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31452

  21. Alexander Schnitzler uploaded patch set 8 01/11/19, 17:21

  22. TYPO3com voted on patch set 8 V +1 01/11/19, 17:31 Completed build in 10m 02s on Fri, 11 Jan, 06:31 PM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31454

  23. Anja Leichsenring voted on patch set 8 V +1 CR +1 01/11/19, 19:17

  24. Benni Mack voted on patch set 8 V +2 CR +2 01/12/19, 20:30

  25. Benni Mack merged patch set 9 01/12/19, 20:30