Review 9.5 Merged

59383[BUGFIX] Install tool: Allow row updater as valid identifier

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/09/19, 13:32

Commit message

In `UpgradeWizardService::assertIdentifierIsValid` check if the
identifier is a subclass of `RowUpdaterInterface` to avoid an exception
being thrown, when marking a row updater as undone.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 01/09/19, 13:11

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/09/19, 13:26 Completed build in 15m 17s on Wed, 9 Jan, 02:26 PM Test Summary: 49073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-95

  3. Benni Mack voted on patch set 1 V +2 CR +2 01/09/19, 13:32

  4. Benni Mack merged patch set 2 01/09/19, 13:32