Review main Merged

59385[BUGFIX] Use proper exception messages for Scheduler::fetchTask()

Stefanos Karasavvidis CR +2 V +2 Easy +6 −5 updated 02/01/19, 16:45

Commit message

Use a proper message in case a non existent uid was passed and
correctly handle the case where no task uid was passed and no task
is overdue.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Fabien Udriot +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Fabien Udriot +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1520

  1. Stefanos Karasavvidis uploaded patch set 1 01/09/19, 13:29

  2. TYPO3com voted on patch set 1 V -1 01/09/19, 13:29 Completed build in 09s on Wed, 9 Jan, 02:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31364

  3. Stefanos Karasavvidis uploaded patch set 2 01/09/19, 13:31

  4. TYPO3com voted on patch set 2 V +1 01/09/19, 13:45 Completed build in 13m 36s on Wed, 9 Jan, 02:45 PM Test Summary: 47629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31366

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/18/19, 14:09

  6. Andreas Kienast uploaded patch set 3 01/19/19, 19:04

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 01/19/19, 19:04

  8. Andreas Kienast updated the commit message in patch set 4 01/19/19, 19:04

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 01/19/19, 19:05

  10. TYPO3com voted on patch set 4 V +1 01/19/19, 19:18 Completed build in 13m 19s on Sat, 19 Jan, 08:18 PM Test Summary: 46897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31664

  11. TYPO3com voted on patch set 3 V +1 01/19/19, 19:18 Completed build in 14m 48s on Sat, 19 Jan, 08:18 PM Test Summary: 46897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31663

  12. Stefanos Karasavvidis voted on patch set 4 V +1 CR +1 01/19/19, 19:49

  13. Daniel Goerz commented on patch set 5 01/20/19, 17:10

    Published edit on patch set 4.
  14. Daniel Goerz voted on patch set 5 V +1 CR +1 01/20/19, 17:10

  15. TYPO3com voted on patch set 5 V +1 01/20/19, 17:21 Completed build in 10m 33s on Sun, 20 Jan, 06:21 PM Test Summary: 46897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31674

  16. Fabien Udriot voted on patch set 5 V +1 CR +1 01/23/19, 15:40

  17. Susi Moog voted on patch set 5 V +1 CR +1 02/01/19, 16:42

  18. Anja Leichsenring voted on patch set 5 V +2 CR +2 02/01/19, 16:44

  19. Anja Leichsenring merged patch set 6 02/01/19, 16:44

  20. Anja Leichsenring commented on patch set 6 02/01/19, 16:45

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 8e2177127c6734ab6429ada6570830ceed704872