Review TYPO3_8-7 Merged

59389[BUGFIX] Avoid fatal when flushed directory is a symlink

Mathias Brodala CR +2 V +2 Easy +6 −1 updated 01/09/19, 16:14

Commit message

\TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory tries to
rename the given directory to be able to atomically flush the
contents of the directory. This however fails, when the given
folder is a symlink.

We now catch this case by checking whether the given directory
is a symlink and resolve it with realpath.

While this does not cover all possible cases, it improves the
case where the folder containing the symlink is also writable.

Review

  • Code review CR +2
    • Mathias Brodala +2
  • Verified V +2
    • Mathias Brodala +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Mathias Brodala commented on patch set 1 01/09/19, 15:28

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/09/19, 16:08 Completed build in 38m 25s on Wed, 9 Jan, 05:08 PM Test Summary: 79478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3362

  3. Mathias Brodala voted on patch set 1 V +2 CR +2 01/09/19, 16:14

  4. Mathias Brodala merged patch set 2 01/09/19, 16:14