Review main Merged

59390[BUGFIX] Make nested slugs in rootpages possible

Benni Mack CR +2 V +2 Easy +3 −3 updated 01/11/19, 17:04

Commit message

If there are nested sites, the rootpage of the
nested site cannot have the slug "/" as the uniqueInSite
evaluates against the parent page, and not the actual
page.

Instead of taking the PID of the parent page ID, the uid
of the localized record is used.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Daniel Gorges +1
  • Verified V +2
    • Anja Leichsenring +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 01/09/19, 16:06

  2. TYPO3com voted on patch set 1 V -1 01/09/19, 16:15 Completed build in 08m 31s on Wed, 9 Jan, 05:15 PM Test Summary: 4 of 48022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31378

  3. Benni Mack uploaded patch set 2 01/11/19, 12:31

  4. TYPO3com voted on patch set 2 V -1 01/11/19, 12:52 Completed build in 16m 55s on Fri, 11 Jan, 01:52 PM Test Summary: 4 of 48034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31428

  5. Benni Mack uploaded patch set 3 01/11/19, 12:58

  6. TYPO3com voted on patch set 3 V +1 01/11/19, 13:09 Completed build in 10m 30s on Fri, 11 Jan, 02:09 PM Test Summary: 47641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31429

  7. Daniel Gorges voted on patch set 3 V +1 CR +1 01/11/19, 13:11

  8. Anja Leichsenring commented on patch set 3 01/11/19, 15:42

    can I please get a more complete error description? From the code and the adjusted test I can not define a testing scenario, sorry.
  9. Anja Leichsenring commented on patch set 3 V +2 CR +2 01/11/19, 17:03

    so it is: 1. make a root page below a defined root page with site config 2. define a new site config for the sub site, best with a complete new URL 3. edit the subpage, try setting the slug to '/' -> with patch it works, without you end up with '/1'
  10. Anja Leichsenring merged patch set 4 01/11/19, 17:03

  11. Anja Leichsenring commented on patch set 4 01/11/19, 17:04

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit ec5c889f3b07788528736ad5454f2e626cb8764e