Review main Merged

59397[TASK] Remove unit tests that do not test the subject

Christian Kuhn CR +2 V +2 Easy +0 −38 updated 01/10/19, 12:09

Commit message

Some tests in FrontendLoginControllerTest test only
GeneralUtility::getIndpEnv(), but not the system under
test FrontendLoginController. Remove those.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 01/10/19, 11:30

  2. TYPO3com voted on patch set 1 V +1 01/10/19, 11:39 Completed build in 09m 33s on Thu, 10 Jan, 12:39 PM Test Summary: 47609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31397

  3. Mathias Brodala commented on patch set 1 01/10/19, 11:53

    Would it make sense to move these to GeneralUtilityTest?
  4. Wouter Wolters voted on patch set 1 V +2 CR +2 01/10/19, 12:09

  5. Wouter Wolters merged patch set 2 01/10/19, 12:09