Review main Merged

59399[TASK] Remove checks for CRYPT_MD5 and CRYPT_BLOWFISH availability

Stefanos Karasavvidis CR +2 V +2 Easy +0 −20 updated 01/11/19, 11:29

Commit message

According to crypt() documentation "As of PHP 5.3.0, PHP contains its
own implementation and will use that if the system lacks of support
for one or more of the algorithms.". So these checks are not
necessary anymore.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 68

  1. Stefanos Karasavvidis uploaded patch set 1 01/11/19, 09:15

  2. TYPO3com voted on patch set 1 V +1 01/11/19, 09:24 Completed build in 09m 42s on Fri, 11 Jan, 10:24 AM Test Summary: 47609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31413

  3. Stefanos Karasavvidis updated the commit message in patch set 2 01/11/19, 09:48

  4. TYPO3com voted on patch set 2 V +1 01/11/19, 10:02 Completed build in 13m 16s on Fri, 11 Jan, 11:02 AM Test Summary: 47609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31417

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 01/11/19, 10:05

  6. Stefanos Karasavvidis commented on patch set 2 01/11/19, 10:12

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 4a92762f3997b3205fa8619e227375a10af1cbad
  7. Georg Ringer voted on patch set 2 V +2 CR +2 01/11/19, 11:29

  8. Georg Ringer merged patch set 3 01/11/19, 11:29