Review 9.5 Abandoned

59411[BUGFIX] Respect enableFields when counting result

Getdesigned GmbH CR 0 V 0 Normal +68 −0 updated 10/25/19, 19:34

Commit message

The legacy translation overlay handling
(consistentTranslationOverlayHandling = 0) of Extbase has to respect
enableFields of localized records when the language overlay mode is set to
`hideNonTranslated`. Otherwise counting query results may lead to
inaccurate numbers.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 810

  1. Getdesigned GmbH uploaded patch set 1 01/11/19, 14:15

  2. TYPO3com voted on patch set 1 V +1 01/11/19, 14:31 Completed build in 15m 21s on Fri, 11 Jan, 03:31 PM Test Summary: 49073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-120

  3. Frank Nägler voted on patch set 1 CR +1 03/03/19, 20:31

  4. Markus Klein commented on patch set 1 03/04/19, 22:59

    This definitely needs to be covered with tests. I suppose \sysext\extbase\Tests\Functional\Persistence\TranslationTest.php is the right place.
  5. Getdesigned GmbH uploaded patch set 2 03/05/19, 17:09

  6. Getdesigned GmbH commented on patch set 2 03/05/19, 17:12

    Right, thought about that recently. Thanks for pointing me to the proper file! Test is added. I've introduced an additional dataset language in order to not mess up existing tests. Hope that's ok.
  7. TYPO3com voted on patch set 2 V +1 03/05/19, 17:21 Completed build in 11m 46s on Tue, 5 Mar, 06:21 PM Test Summary: 49546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-329

  8. Markus Klein commented on patch set 2 03/05/19, 21:22

    TranslationTest.php:210 Unresolved

    We have two dedicated files for the tests with the old and new API. We should therefore add here only those for the new "consistent...handling" and the old ones in \TYPO3\CMS\Extbase\Tests\Functional\Persistence\TranslationLegacyTest Moreover we should extend the patch to be applied to master as well, in order to have the tests within this file available there as well.
  9. Markus Klein commented on patch set 2 CR -1 03/05/19, 21:31

    Sorry, I took a deeper look into this patch again and realized that you are intending to fix something that is known to be broken, but would be rather unexpected to be fixed. Please see https://docs.typo3.org/typo3cms/extensions/core/latest/Changelog/9.5/Important-82363-MakeExtBaseTranslationHandlingConsistentWithTyposcript.html#impact for details. Specifically the sentence: Previously Typo3QuerySettings->languageOverlayMode had no effect. Extbase always performed an overlay process on the result set. We spent a huge amount of time back then in analyzing the broken state of extbase in this area. The outcome was the new consistent handling stuff, which should take care of hideNonTranslated properly.
  10. Susi Moog abandoned the change 10/25/19, 19:34

    As mentioned by Markus, we don't change the legacy behaviour of the extbase localization mechanics. Please use the new, consistent translation overlay handling in the future.