Review main Merged

59414[BUGFIX] Allow to access pages with "index.php?id=123"

Michael Giek CR +2 V +2 Easy +22 −6 updated 01/11/19, 21:42

Commit message

Currently, the SiteMatcher checks for "?id=123&L=123" for special
treatment when Site Handling is enabled.

However, it should be possible to only access
www.example.com/index.php?id=123, without the "L" parameter,
for pages with Site-handling.

Without the patch, the language is not resolved, and a redirect
to /fr/ (or whatever default language prefix is given) is made.

Tests are adapted so IDs with ?id=1000 are not redirected
anymore.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 813

  1. Michael Giek uploaded patch set 1 01/11/19, 15:26

  2. Michael Giek updated the commit message in patch set 2 01/11/19, 15:28

  3. TYPO3com voted on patch set 1 V -1 01/11/19, 15:30 Completed build in 31s on Fri, 11 Jan, 04:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31440

  4. TYPO3com voted on patch set 2 V -1 01/11/19, 15:30 Completed build in 40s on Fri, 11 Jan, 04:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31441

  5. Michael Giek uploaded patch set 3 01/11/19, 15:36

  6. TYPO3com voted on patch set 3 V -1 01/11/19, 15:48 Completed build in 12m 49s on Fri, 11 Jan, 04:48 PM Test Summary: 6 of 48034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31443

  7. Benni Mack rebased onto patch set 4 01/11/19, 16:24

  8. TYPO3com voted on patch set 4 V -1 01/11/19, 16:35 Completed build in 11m 06s on Fri, 11 Jan, 05:35 PM Test Summary: 6 of 48038 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31449

  9. Benni Mack uploaded patch set 5 01/11/19, 16:40

  10. TYPO3com voted on patch set 5 V +1 01/11/19, 16:51 Completed build in 11m 24s on Fri, 11 Jan, 05:51 PM Test Summary: 47639 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31451

  11. Benni Mack voted on patch set 5 V +1 CR +1 01/11/19, 20:26

  12. Anja Leichsenring voted on patch set 5 V +2 CR +2 01/11/19, 21:42

  13. Anja Leichsenring merged patch set 6 01/11/19, 21:42