59417[BUGFIX] Use argument $tparams BackendUtility::thumbCode for FAL items
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Fabien Udriot +1
- Benni Mack +1
-
Verified V +2
- Georg Ringer +2
- Fabien Udriot +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1011
-
Georg Ringer uploaded patch set 1 01/11/19, 20:00
-
TYPO3com voted on patch set 1 V +1 01/11/19, 20:11 Completed build in 10m 40s on Fri, 11 Jan, 09:11 PM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31459
-
Benni Mack voted on patch set 1 V +1 CR +1 01/14/19, 05:17
-
Oliver Klee commented on patch set 1 01/14/19, 11:15
-
Georg Ringer commented on patch set 1 01/14/19, 11:46
BackendUtility.php:1167Replyit's called $tParams and argument of the method thumbCode -
Oliver Klee commented on patch set 1 01/14/19, 11:50
BackendUtility.php:1167ReplyAh, okay. I completely missed that. Thanks! -
Oliver Klee commented on patch set 1 01/14/19, 14:34
BackendUtility.php:1167ReplyWill we also need spaces around $tparams? Or is it supposed to already start with a space? -
Fabien Udriot voted on patch set 1 V +1 CR +1 01/14/19, 14:43
-
Georg Ringer voted on patch set 1 V +2 CR +2 01/14/19, 18:23
-
Georg Ringer merged patch set 2 01/14/19, 18:23
-
Georg Ringer commented on patch set 2 01/14/19, 18:24
Cherry Picked This patchset was cherry picked to branch 9.5 as commit 3033fb22ebc0af85e6d85bcea8b76cf2f9f7ca11
BackendUtility.php:1167