Review main Merged

59418[BUGFIX] Check for unset font if text is set in GIFBUILDER

Tom Novotny CR +2 V +2 Easy +4 −1 updated 01/13/19, 19:59

Commit message

You can set a text without defining a font file to be used, explicitly.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Tom Novotny uploaded patch set 1 01/11/19, 20:55

  2. TYPO3com voted on patch set 1 V -1 01/11/19, 20:55 Completed build in 18s on Fri, 11 Jan, 09:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31462

  3. Tom Novotny uploaded patch set 2 01/11/19, 21:07

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 01/11/19, 21:12

  5. TYPO3com voted on patch set 2 V +1 01/11/19, 21:19 Completed build in 11m 18s on Fri, 11 Jan, 10:19 PM Test Summary: 47645 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31464

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/13/19, 19:59

  7. Benni Mack merged patch set 3 01/13/19, 19:59

  8. Benni Mack commented on patch set 3 01/13/19, 19:59

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 1e1afb6c88cec039b965dbc81d84f1a3d50e6408