Review main Merged

59422[TASK] Improve ClassSchema methods api

Alexander Schnitzler CR +2 V +2 Expert +948 −382 updated 02/01/19, 15:44

Commit message

This patch introduces a new Method class to have an
easier and more stable api to get information about class
methods from ClassSchema objects.

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Method objects are returned for the following calls:

- getMethod
- getMethods
- getInjectMethods

Also it removes the following method:

- getConstructorArguments

The following constants are marked as private:

- ClassSchema::MODELTYPE_ENTITY
- ClassSchema::MODELTYPE_VALUEOBJECT

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • Mona Muzaffar +1
    • André Buchmann +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • Mona Muzaffar +1
    • André Buchmann +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 2837

Show 812 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 01/13/19, 12:49

  2. TYPO3com voted on patch set 1 V -1 01/13/19, 12:58 Completed build in 09m 11s on Sun, 13 Jan, 01:58 PM Test Summary: 47635 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31471

  3. Alexander Schnitzler uploaded patch set 2 01/13/19, 13:31

  4. TYPO3com voted on patch set 2 V -1 01/13/19, 13:40 Completed build in 08m 54s on Sun, 13 Jan, 02:40 PM Test Summary: 4 of 48028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31472

  5. Alexander Schnitzler uploaded patch set 3 01/14/19, 10:02

  6. Alexander Schnitzler wrote 01/14/19, 10:03

    Topic set to extbase
  7. TYPO3com voted on patch set 3 V +1 01/14/19, 10:11 Completed build in 08m 49s on Mon, 14 Jan, 11:11 AM Test Summary: 47631 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31478

  8. Alexander Schnitzler updated the commit message in patch set 4 01/14/19, 10:40

  9. TYPO3com voted on patch set 4 V +1 01/14/19, 10:52 Completed build in 11m 45s on Mon, 14 Jan, 11:52 AM Test Summary: 47631 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31480

  10. Anja Leichsenring commented on patch set 4 01/28/19, 19:14

    nice one. I suggest to have this as breaking with a rst file, so extension authors are not surprised if they use the old API.

    ObjectConverter.php:139 Unresolved

    nothing to do in case of this exceptions? Please add a little comment, why they are not handled.

    ClassSchema.php:636

    this needs to be a deprecation. The method is released in v9 and public, so it can not be dropped just like that.

    NoSuchMethodException.php:3 Unresolved

    Licence Header is missing.

    NoSuchMethodParameterException.php:3 Unresolved

    also here
  11. Alexander Schnitzler commented on patch set 4 01/28/19, 19:50

    ClassSchema.php:636 Reply Unresolved

    I disagree here because the whole class is marked internal. This is no public api and it slows us down to deprecate and document all internal changes.
  12. Anja Leichsenring commented on patch set 4 01/28/19, 19:52

    > Patch Set 4: > > (1 comment) all right, accepted. Would still be nice to have it included in scanner and rst. Get me right here: would be nice.
  1. Alexander Schnitzler rebased onto patch set 5 01/28/19, 19:52

  2. Alexander Schnitzler uploaded patch set 6 01/28/19, 20:07

  3. TYPO3com voted on patch set 5 V +1 01/28/19, 20:16 Completed build in 24m 08s on Mon, 28 Jan, 09:16 PM Test Summary: 46890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31795

  4. TYPO3com voted on patch set 6 V +1 01/28/19, 20:20 Completed build in 13m 20s on Mon, 28 Jan, 09:20 PM Test Summary: 46890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31796

  5. Anja Leichsenring voted on patch set 6 V +1 CR +1 01/29/19, 19:41

  6. Andreas Wolf voted on patch set 6 CR +2 02/01/19, 10:15

  7. Andreas Wolf voted on patch set 6 V +1 CR +1 02/01/19, 11:55

  8. Andreas Kienast commented on patch set 6 V -1 02/01/19, 13:42

    Cannot use object of type TYPO3\CMS\Extbase\Reflection\ClassSchema\MethodParameter as array Reproducable by setting e.g. "max" or "time" in EXT:belog
  9. Andreas Kienast uploaded patch set 7 02/01/19, 13:43

  10. Mona Muzaffar voted on patch set 6 V +1 02/01/19, 13:44

  11. TYPO3com voted on patch set 7 V +1 02/01/19, 13:55 Completed build in 11m 36s on Fri, 1 Feb, 02:55 PM Test Summary: 46924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31913

  12. Andreas Kienast commented on patch set 7 CR -1 02/01/19, 13:57

    on it again
  13. Andreas Kienast uploaded patch set 8 02/01/19, 14:04

  14. Andreas Kienast voted on patch set 8 V +1 CR +1 02/01/19, 14:05

  15. Mona Muzaffar voted on patch set 8 V +1 CR +1 02/01/19, 14:13

  16. TYPO3com voted on patch set 8 V +1 02/01/19, 14:15 Completed build in 11m 06s on Fri, 1 Feb, 03:15 PM Test Summary: 46924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31916

  17. Andreas Kienast voted on patch set 8 CR -1 02/01/19, 14:18

  18. Andreas Kienast uploaded patch set 9 02/01/19, 14:19

  19. Andreas Kienast voted on patch set 9 V +1 CR +1 02/01/19, 14:20

  20. Mona Muzaffar voted on patch set 9 V +1 CR +1 02/01/19, 14:20

  21. TYPO3com voted on patch set 9 V +1 02/01/19, 14:39 Completed build in 15m 50s on Fri, 1 Feb, 03:39 PM Test Summary: 46924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31919

  22. André Buchmann commented on patch set 9 CR -1 02/01/19, 14:51

    I'm on it
  23. André Buchmann voted on patch set 9 V +1 CR +1 02/01/19, 15:23

  24. Anja Leichsenring voted on patch set 9 V +2 CR +2 02/01/19, 15:44

  25. Anja Leichsenring merged patch set 10 02/01/19, 15:44