59422[TASK] Improve ClassSchema methods api
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Andreas Kienast +1
- Mona Muzaffar +1
- André Buchmann +1
-
Verified V +2
- Anja Leichsenring +2
- Andreas Kienast +1
- Mona Muzaffar +1
- André Buchmann +1
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/core/Documentation/Changelog/master/Important-87427-ClassSchemaConstantsMarkedAsPrivate.rstnew+17 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+13 −16
- typo3/sysext/extbase/Classes/Object/Container/Container.php+31 −15
- typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php1+23 −15
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Exception/NoSuchMethodException.php1new+36 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Exception/NoSuchMethodParameterException.php1new+51 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Method.phpnew+179 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/MethodParameter.phpnew+143 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php2+60 −42
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+92 −75
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/ObjectConverterTest.php+11 −7
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+33 −15
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodParameterTest.phpnew+163 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodTest.phpnew+86 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+0 −197
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassConstantMatcher.php+10 −0
Review log 2837
Show 812 earlier messages
-
Alexander Schnitzler uploaded patch set 1 01/13/19, 12:49
-
TYPO3com voted on patch set 1 V -1 01/13/19, 12:58 Completed build in 09m 11s on Sun, 13 Jan, 01:58 PM Test Summary: 47635 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31471
-
Alexander Schnitzler uploaded patch set 2 01/13/19, 13:31
-
TYPO3com voted on patch set 2 V -1 01/13/19, 13:40 Completed build in 08m 54s on Sun, 13 Jan, 02:40 PM Test Summary: 4 of 48028 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31472
-
Alexander Schnitzler uploaded patch set 3 01/14/19, 10:02
-
Alexander Schnitzler wrote 01/14/19, 10:03
Topic set to extbase -
TYPO3com voted on patch set 3 V +1 01/14/19, 10:11 Completed build in 08m 49s on Mon, 14 Jan, 11:11 AM Test Summary: 47631 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31478
-
Alexander Schnitzler updated the commit message in patch set 4 01/14/19, 10:40
-
TYPO3com voted on patch set 4 V +1 01/14/19, 10:52 Completed build in 11m 45s on Mon, 14 Jan, 11:52 AM Test Summary: 47631 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31480
-
Anja Leichsenring commented on patch set 4 01/28/19, 19:14
nice one. I suggest to have this as breaking with a rst file, so extension authors are not surprised if they use the old API.ObjectConverter.php:139Unresolvednothing to do in case of this exceptions? Please add a little comment, why they are not handled.ClassSchema.php:636this needs to be a deprecation. The method is released in v9 and public, so it can not be dropped just like that.NoSuchMethodException.php:3UnresolvedLicence Header is missing.NoSuchMethodParameterException.php:3Unresolvedalso here -
Alexander Schnitzler commented on patch set 4 01/28/19, 19:50
ClassSchema.php:636Reply UnresolvedI disagree here because the whole class is marked internal. This is no public api and it slows us down to deprecate and document all internal changes. -
Anja Leichsenring commented on patch set 4 01/28/19, 19:52
> Patch Set 4: > > (1 comment) all right, accepted. Would still be nice to have it included in scanner and rst. Get me right here: would be nice.
-
Alexander Schnitzler rebased onto patch set 5 01/28/19, 19:52
-
Alexander Schnitzler uploaded patch set 6 01/28/19, 20:07
-
TYPO3com voted on patch set 5 V +1 01/28/19, 20:16 Completed build in 24m 08s on Mon, 28 Jan, 09:16 PM Test Summary: 46890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31795
-
TYPO3com voted on patch set 6 V +1 01/28/19, 20:20 Completed build in 13m 20s on Mon, 28 Jan, 09:20 PM Test Summary: 46890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31796
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 01/29/19, 19:41
-
Andreas Wolf voted on patch set 6 CR +2 02/01/19, 10:15
-
Andreas Wolf voted on patch set 6 V +1 CR +1 02/01/19, 11:55
-
Andreas Kienast commented on patch set 6 V -1 02/01/19, 13:42
Cannot use object of type TYPO3\CMS\Extbase\Reflection\ClassSchema\MethodParameter as array Reproducable by setting e.g. "max" or "time" in EXT:belog -
Andreas Kienast uploaded patch set 7 02/01/19, 13:43
-
Mona Muzaffar voted on patch set 6 V +1 02/01/19, 13:44
-
TYPO3com voted on patch set 7 V +1 02/01/19, 13:55 Completed build in 11m 36s on Fri, 1 Feb, 02:55 PM Test Summary: 46924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31913
-
Andreas Kienast commented on patch set 7 CR -1 02/01/19, 13:57
on it again -
Andreas Kienast uploaded patch set 8 02/01/19, 14:04
-
Andreas Kienast voted on patch set 8 V +1 CR +1 02/01/19, 14:05
-
Mona Muzaffar voted on patch set 8 V +1 CR +1 02/01/19, 14:13
-
TYPO3com voted on patch set 8 V +1 02/01/19, 14:15 Completed build in 11m 06s on Fri, 1 Feb, 03:15 PM Test Summary: 46924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31916
-
Andreas Kienast voted on patch set 8 CR -1 02/01/19, 14:18
-
Andreas Kienast uploaded patch set 9 02/01/19, 14:19
-
Andreas Kienast voted on patch set 9 V +1 CR +1 02/01/19, 14:20
-
Mona Muzaffar voted on patch set 9 V +1 CR +1 02/01/19, 14:20
-
TYPO3com voted on patch set 9 V +1 02/01/19, 14:39 Completed build in 15m 50s on Fri, 1 Feb, 03:39 PM Test Summary: 46924 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31919
-
André Buchmann commented on patch set 9 CR -1 02/01/19, 14:51
I'm on it -
André Buchmann voted on patch set 9 V +1 CR +1 02/01/19, 15:23
-
Anja Leichsenring voted on patch set 9 V +2 CR +2 02/01/19, 15:44
-
Anja Leichsenring merged patch set 10 02/01/19, 15:44