Review main Merged

59442[BUGFIX] Drop a unit test that relies on uploads folder

Christian Kuhn CR +2 V +2 Easy +0 −1 updated 01/15/19, 13:25

Commit message

With the removal of type=group internal_type=file and
file_reference, the uploads folder is obsolete. The
patch drops a last unit test that relies on its
existance, so typo3/testing-framework no longer
needs to create that directory for tests.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Alexander Schnitzler +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Alexander Schnitzler +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Kuhn uploaded patch set 1 01/15/19, 12:30

  2. Christian Kuhn uploaded patch set 2 01/15/19, 12:36

  3. Christian Kuhn voted on patch set 2 CR -1 01/15/19, 12:36

  4. Christian Kuhn uploaded patch set 3 01/15/19, 12:39

  5. TYPO3com voted on patch set 1 V -1 01/15/19, 12:41 Completed build in 11m 16s on Tue, 15 Jan, 01:41 PM Test Summary: 4 of 47977 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31510

  6. Christian Kuhn commented on patch set 3 V +1 CR +1 01/15/19, 12:43

    no-brainish.
  7. Wouter Wolters voted on patch set 3 V +1 CR +1 01/15/19, 12:45

  8. TYPO3com voted on patch set 2 V -1 01/15/19, 12:50 Completed build in 13m 58s on Tue, 15 Jan, 01:50 PM Test Summary: 47580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31511

  9. TYPO3com voted on patch set 3 V +1 01/15/19, 12:52 Completed build in 13m 54s on Tue, 15 Jan, 01:52 PM Test Summary: 47580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31512

  10. Alexander Schnitzler voted on patch set 3 V +1 CR +1 01/15/19, 13:18

  11. Wouter Wolters voted on patch set 3 V +2 CR +2 01/15/19, 13:25

  12. Wouter Wolters merged patch set 4 01/15/19, 13:25