Review main Merged

59444[BUGFIX] Respect columnsOverrides in TCA for suggest wizard

Daniel Siepmann CR +2 V +2 Easy +8 −0 updated 04/07/20, 22:02

Commit message

These changes in the SuggestWizardController allow users to override
allowed tables in group fields with columnsOverrides.

Typical usecases for this is to use the records field for tt_content
elements.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2229

Show 34 earlier messages
  1. Daniel Siepmann uploaded patch set 1 01/15/19, 13:42

  2. Daniel Siepmann commented on patch set 1 01/15/19, 13:44

    This is more or a less an proposal. A far better way would be to use the FormEngine to gather all data, e.g. page ts config and further stuff. Still this is an improvement to currently not applied configuration, leading to a non usable situation.
  3. TYPO3com voted on patch set 1 V +1 01/15/19, 13:58 Completed build in 10m 43s on Tue, 15 Jan, 02:58 PM Test Summary: 47546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31521

  4. Mathias Brodala commented on patch set 1 CR -1 01/15/19, 14:06

    This must be 9.5 and only if really important also 8.7.
  1. Daniel Siepmann updated the commit message in patch set 2 01/15/19, 14:07

  2. Daniel Siepmann commented on patch set 1 01/15/19, 14:09

    I hit this bug in 7, 8 and 9. At least for me it's very important to also get it in 8.7. Adjusted master to 9.5.
  3. Daniel Siepmann commented on patch set 2 01/15/19, 14:09

    Reply

    I hit this bug in 7, 8 and 9. At least for me it's very important to also get it in 8.7. Adjusted master to 9.5.
  4. Mathias Brodala updated the commit message in patch set 3 01/15/19, 14:12

  5. Mathias Brodala commented on patch set 3 01/15/19, 14:13

    > I hit this bug in 7, 8 and 9. At least for me it's very important > to also get it in 8.7. Adjusted master to 9.5. But it must go into master first. ;-) Adjusted once more.
  6. TYPO3com voted on patch set 2 V +1 01/15/19, 14:21 Completed build in 13m 34s on Tue, 15 Jan, 03:21 PM Test Summary: 47546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31522

  7. TYPO3com voted on patch set 3 V +1 01/15/19, 14:26 Completed build in 11m 41s on Tue, 15 Jan, 03:26 PM Test Summary: 47546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31524

  8. Jörg Bösche voted on patch set 3 CR +1 02/07/19, 14:54

  9. Daniel Siepmann marked it work in progress 06/21/19, 14:55

  10. Daniel Siepmann uploaded patch set 4 06/22/19, 09:26

  11. TYPO3com voted on patch set 4 V +1 06/22/19, 09:37 Completed build in 10m 58s on Sat, 22 Jun, 11:37 AM Test Summary: 46478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34508

  12. Daniel Siepmann uploaded patch set 5 10/25/19, 16:06

  13. TYPO3com voted on patch set 5 V +1 10/25/19, 16:19 Completed build in 12m 17s on Fri, 25 Oct, 04:19 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37711

  14. Daniel Siepmann uploaded patch set 6 04/07/20, 08:57

  15. Daniel Siepmann commented on patch set 6 04/07/20, 08:57

    This change is ready for review.
  16. Daniel Siepmann commented on patch set 6 04/07/20, 08:59

    Can be tested with the following adjustment, e.g. in file Configuration/TCA/Overrides/tt_content_shortcut.php: <?php defined('TYPO3_MODE') or die(); (function (string $table, string $contentType) { \TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule($GLOBALS['TCA'][$table], [ 'types' => [ $contentType => [ 'columnsOverrides' => [ 'records' => [ 'config' => [ 'allowed' => 'be_users', ], ], ], ], ], 'columns' => [ 'records' => [ 'config' => [ 'allowed' => $GLOBALS['TCA'][$table]['columns']['records']['config']['allowed'] . ',be_users', ], ], ], ]); })('tt_content', 'shortcut');
  17. Daniel Siepmann commented on patch set 6 04/07/20, 09:01

    Copy and paste solution from https://review.typo3.org/c/Packages/TYPO3.CMS/+/61416 Still I would highly recommend an public API to not copy and paste the code block. But I'm not to much into the API and don't know where to put it.
  18. Daniel Siepmann uploaded patch set 7 04/07/20, 09:03

  19. Daniel Siepmann commented on patch set 7 04/07/20, 09:06

    Reply

    Done
  20. TYPO3com voted on patch set 6 V +1 04/07/20, 09:09 Completed build in 12m 16s on Tue, 7 Apr, 09:09 AM Test Summary: 73361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2260

  21. TYPO3com voted on patch set 7 V +1 04/07/20, 09:20 Completed build in 13m 56s on Tue, 7 Apr, 09:20 AM Test Summary: 73363 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2262

  22. Josef Glatz voted on patch set 7 V +1 CR +1 04/07/20, 20:04

  23. Oli Bartsch voted on patch set 7 V +1 CR +1 04/07/20, 21:01

  24. Georg Ringer voted on patch set 7 V +2 CR +2 04/07/20, 22:01

  25. Georg Ringer merged patch set 8 04/07/20, 22:02