59447[TASK] Add hidden field to form definition example
Commit message
Review
-
Code review CR +2
- Mathias Brodala +2
- Daniel Goerz +1
- Josef Glatz +1
- Björn Jacob +1
-
Verified V +2
- Mathias Brodala +2
- Daniel Goerz +1
- Josef Glatz +1
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1317
-
TYPO3com uploaded patch set 1 01/15/19, 14:45
-
TYPO3com voted on patch set 1 V +1 01/15/19, 14:57 Completed build in 12m 14s on Tue, 15 Jan, 03:57 PM Test Summary: 47546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31530
-
Georg Ringer voted on patch set 1 V +1 CR +1 01/16/19, 07:10
-
Josef Glatz commented on patch set 1 CR -1 01/16/19, 07:31
the message must by more generic IMO -
Josef Glatz updated the commit message in patch set 2 01/19/19, 13:52
-
TYPO3com voted on patch set 2 V +1 01/19/19, 14:04 Completed build in 11m 15s on Sat, 19 Jan, 03:04 PM Test Summary: 46897 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31661
-
Daniel Goerz voted on patch set 2 V +1 CR +1 01/20/19, 17:12
-
Josef Glatz voted on patch set 2 V +1 CR +1 01/20/19, 17:55
-
Mathias Brodala updated the commit message in patch set 3 01/21/19, 12:08
-
Mathias Brodala commented on patch set 3 01/21/19, 12:08
Please revote. -
Josef Glatz commented on patch set 3 V +1 CR +1 01/21/19, 12:09
Many thanks Mathias! -
TYPO3com voted on patch set 3 V +1 01/21/19, 12:18 Completed build in 10m 26s on Mon, 21 Jan, 01:18 PM Test Summary: 46894 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31681
-
Daniel Goerz voted on patch set 3 V +1 CR +1 01/21/19, 12:27
-
Björn Jacob commented on patch set 3 CR -1 01/21/19, 12:38
Why do we have a label for the hidden field? -
Björn Jacob commented on patch set 3 V +1 CR +1 01/21/19, 14:38
Okay, Mthias says it could be needed in the confirmation mail. Fine with me. -
Mathias Brodala voted on patch set 3 V +2 CR +2 01/21/19, 14:44
-
Mathias Brodala merged patch set 4 01/21/19, 14:44