Review main Merged

59450[TASK] Deprecate parameter type resolving via doc blocks

Alexander Schnitzler CR +2 V +2 Normal +76 −6 updated 06/14/21, 18:12

Commit message

When a ClassSchema is created for a class, all methods inside said
class are analyzed along with their parameters. Ever since extbase
existed, the parameter type has been read from the doc block.

```
/**
 * @param \Foo\Bar\Baz $baz
 */
public function injectBaz($baz);
```

Since the whole reflection api and PHP itself have been improved
in the recent past, parameter types can be detected without looking
at doc blocks. It is recommended to use native type hints as follows:

```
public function injectBaz(\Foo\Bar\Baz $baz);
```

The doc block is neiter needed nor supported in the near future.
Of course, developers may add a doc block but TYPO3 will no longer
evaluate that as of version 12.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1317

  1. Alexander Schnitzler uploaded patch set 1 01/15/19, 17:18

  2. TYPO3com voted on patch set 1 V +1 01/15/19, 17:28 Completed build in 10m 28s on Tue, 15 Jan, 06:28 PM Test Summary: 47538 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31536

  3. Alexander Schnitzler commented on patch set 1 V -1 01/23/19, 15:50

    Not to be merged before https://review.typo3.org/#/c/59454/
  4. Alexander Schnitzler marked it work in progress 02/16/19, 08:45

  5. Alexander Schnitzler wrote 03/20/20, 14:03

    Topic set to extbase
  6. Benni Mack uploaded patch set 2 05/06/21, 11:29

  7. core-ci voted on patch set 2 V +1 05/06/21, 11:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11246

  8. Benni Mack uploaded patch set 3 05/11/21, 19:32

  9. core-ci voted on patch set 3 V +1 05/11/21, 19:45 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11401

  10. Benni Mack commented on patch set 3 06/14/21, 14:45

    This change is ready for review.
  11. Benni Mack voted on patch set 3 V +1 CR +1 06/14/21, 14:46

  12. Oli Bartsch uploaded patch set 4 06/14/21, 15:08

  13. Oli Bartsch voted on patch set 4 CR +1 06/14/21, 15:09

  14. Oli Bartsch voted on patch set 4 V +1 06/14/21, 15:09

  15. core-ci voted on patch set 4 V +1 06/14/21, 15:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12422

  16. Benni Mack voted on patch set 4 V +2 CR +2 06/14/21, 18:12

  17. Benni Mack merged patch set 5 06/14/21, 18:12