Review 9.5 Merged

59464[BUGFIX] Fix duplicate rendering of 'pages' id-attribute

Moritz Ngo CR +2 V +2 Easy +11 −5 updated 01/17/19, 14:48

Commit message

When translations and (sub-)pages are present at the same time the
'page' id-attribute will be rendered twice.
This ensures that translations and (sub-)pages are independently
collapsible.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Moritz Ngo uploaded patch set 1 01/16/19, 20:08

  2. TYPO3com voted on patch set 1 V +1 01/16/19, 20:22 Completed build in 13m 45s on Wed, 16 Jan, 09:22 PM Test Summary: 49061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-136

  3. Riccardo De Contardi voted on patch set 1 V +1 01/16/19, 20:44

  4. Alexander Stehlik commented on patch set 1 V +1 CR +1 01/16/19, 21:44

    DatabaseRecordList.php:1126

    Just a suggestion: maybe use a different identifier (like page_translations) to prevent confusion with the old pages_language_overlay table.
  5. Alexander Stehlik commented on patch set 1 V 0 01/16/19, 22:06

    Sorry, just realized this is the 9.5 patch. Only tested on master.
  6. Riccardo De Contardi commented on patch set 1 01/17/19, 08:19

    @Alexander I just realized that the same thing happened to me... sorry! I'll pay more attention. My apologies
  7. Christian Kuhn commented on patch set 1 CR -1 01/17/19, 11:12

    this needs an adaption to what happened in the master version if master is being aligned on and merged.
  8. Christian Kuhn uploaded patch set 2 01/17/19, 14:30

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 01/17/19, 14:36

  10. TYPO3com voted on patch set 2 V +1 01/17/19, 14:44 Completed build in 13m 52s on Thu, 17 Jan, 03:44 PM Test Summary: 49061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-140

  11. Anja Leichsenring voted on patch set 2 V +2 CR +2 01/17/19, 14:48

  12. Anja Leichsenring merged patch set 3 01/17/19, 14:48