Review main Merged

59474[BUGFIX] Adapt tests concerning fluid viewhelpers

Anja Leichsenring CR +2 V +2 Normal +33 −24 updated 01/18/19, 17:05

Commit message

Since the release of fluid 2.6.0 unit tests fail due to
changed calling sequence. The unit tests use mocked calls
to keep track of internal sequence.
Using the prophecy mock framework gives better control and fixes
the issue for now.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 914

  1. Anja Leichsenring uploaded patch set 1 01/18/19, 10:13

  2. TYPO3com voted on patch set 1 V -1 01/18/19, 10:13 Completed build in 10s on Fri, 18 Jan, 11:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31591

  3. Anja Leichsenring uploaded patch set 2 01/18/19, 10:16

  4. TYPO3com voted on patch set 2 V -1 01/18/19, 10:32 Completed build in 13m 03s on Fri, 18 Jan, 11:32 AM Test Summary: 8 of 47425 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31592

  5. Anja Leichsenring uploaded patch set 3 01/18/19, 10:41

  6. TYPO3com voted on patch set 3 V -1 01/18/19, 10:41 Completed build in 09s on Fri, 18 Jan, 11:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31593

  7. Anja Leichsenring uploaded patch set 4 01/18/19, 10:42

  8. TYPO3com voted on patch set 4 V +1 01/18/19, 10:58 Completed build in 15m 51s on Fri, 18 Jan, 11:58 AM Test Summary: 47032 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31594

  9. Christian Kuhn commented on patch set 5 01/18/19, 11:00

    Published edit on patch set 4.
  10. TYPO3com voted on patch set 5 V +1 01/18/19, 11:15 Completed build in 14m 47s on Fri, 18 Jan, 12:15 PM Test Summary: 47032 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31596

  11. Christian Kuhn voted on patch set 5 V +1 CR +1 01/18/19, 12:09

  12. Benni Mack voted on patch set 5 V +2 CR +2 01/18/19, 15:15

  13. Benni Mack merged patch set 6 01/18/19, 15:15

  14. Anja Leichsenring commented on patch set 6 01/18/19, 17:05

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 3f434b5b36143ddbcb08e06f72f45cb809c7de15