Review main Merged Breaking

59490[!!!][TASK] Build strict PSR-15 middlewares

Benni Mack CR +2 V +2 Hard +52 −278 updated 02/07/19, 09:07

Commit message

All PSR-15 middlewares now do not set the
$GLOBALS['TYPO3_REQUEST'] object anymore. Instead,
the RequestHandlers are using them for all
other logic (e.g. GP etc) where the request object
or any other attribute has not been handed in
yet.

It is now safe to say that PSR-7 request/response
objects have to be used within middlewares to
access or manipulate GET/POST data. Also,
the safety net for overriding GET/POST again
is still in place for FE (data = GP:id) in
order for existing TypoScript to work still,
until all other code gets global-free.

There are still places in TYPO3 Core where $TYPO3_REQUEST
is necessary (TypoScriptConditionMatcher, Error Handling)
which are added accordingly.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1015

  1. Benni Mack uploaded patch set 1 01/18/19, 19:26

  2. TYPO3com voted on patch set 1 V -1 01/18/19, 19:40 Completed build in 14m 13s on Fri, 18 Jan, 08:40 PM Test Summary: 668 of 47413 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31633

  3. Mathias Brodala commented on patch set 1 01/21/19, 08:08

    RequestHandler.php:60

    ... what? Now I'm curious. ;-)
  4. Benni Mack uploaded patch set 2 01/29/19, 07:21

  5. TYPO3com voted on patch set 2 V -1 01/29/19, 07:31 Completed build in 10m 09s on Tue, 29 Jan, 08:31 AM Test Summary: 24 of 47291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31804

  6. Benni Mack uploaded patch set 3 01/29/19, 11:00

  7. TYPO3com voted on patch set 3 V +1 01/29/19, 11:09 Completed build in 09m 41s on Tue, 29 Jan, 12:09 PM Test Summary: 46874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31808

  8. Benni Mack uploaded patch set 4 02/06/19, 06:52

  9. TYPO3com voted on patch set 4 V +1 02/06/19, 07:06 Completed build in 14m 25s on Wed, 6 Feb, 08:06 AM Test Summary: 46367 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32069

  10. Georg Ringer voted on patch set 4 V +1 CR +1 02/06/19, 07:08

  11. Benni Mack commented on patch set 5 02/07/19, 07:44

    Published edit on patch set 4.
  12. Anja Leichsenring voted on patch set 5 V +1 CR +1 02/07/19, 07:44

  13. TYPO3com voted on patch set 5 V +1 02/07/19, 07:56 Completed build in 12m 30s on Thu, 7 Feb, 08:56 AM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32085

  14. Georg Ringer voted on patch set 5 V +2 CR +2 02/07/19, 09:07

  15. Georg Ringer merged patch set 6 02/07/19, 09:07