Review main Merged Breaking

59492[!!!][TASK] Drop TBE_TEMPLATE variable

Benni Mack CR +2 V +2 Normal +71 −169 updated 01/29/19, 07:19

Commit message

The global variable TBE_TEMPLATE is not
necessary anymore, and is not available anymore.

The change is still ugly, as TBE_TEMPLATE
initializes the PageRenderer object
with necessary information, which should
become built inside PageRenderer for BE. This has been
moved to Backend's RequestHandler where this can be
abstracted further at a later point.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 914

  1. Benni Mack uploaded patch set 1 01/18/19, 20:53

  2. TYPO3com voted on patch set 1 V -1 01/18/19, 21:07 Completed build in 14m 37s on Fri, 18 Jan, 10:07 PM Test Summary: 8 of 25433 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31645

  3. Benni Mack uploaded patch set 2 01/19/19, 20:40

  4. TYPO3com voted on patch set 2 V -1 01/19/19, 20:51 Completed build in 11m 01s on Sat, 19 Jan, 09:51 PM Test Summary: 8 of 47290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31665

  5. Benni Mack uploaded patch set 3 01/28/19, 19:49

  6. TYPO3com voted on patch set 3 V -1 01/28/19, 20:03 Completed build in 13m 24s on Mon, 28 Jan, 09:03 PM Test Summary: 8 of 47291 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31793

  7. Benni Mack uploaded patch set 4 01/28/19, 20:18

  8. TYPO3com voted on patch set 4 V +1 01/28/19, 20:29 Completed build in 11m 13s on Mon, 28 Jan, 09:29 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31797

  9. Benni Mack uploaded patch set 5 01/29/19, 06:02

  10. TYPO3com voted on patch set 5 V +1 01/29/19, 06:13 Completed build in 10m 29s on Tue, 29 Jan, 07:13 AM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31803

  11. Georg Ringer voted on patch set 5 V +1 CR +1 01/29/19, 06:31

  12. Daniel Gorges voted on patch set 5 V +1 CR +1 01/29/19, 07:18

  13. Benni Mack voted on patch set 5 V +2 CR +2 01/29/19, 07:19

  14. Benni Mack merged patch set 6 01/29/19, 07:19