Review main Merged

59505[BUGFIX] Use overridden field label in list view

Georg Ringer CR +2 V +2 Easy +37 −6 updated 01/30/19, 05:47

Commit message

If a label of a table column is overridden by TsConfig
(TCEFORM.<table>.<column>.label), the new value
must also be used in the list view:

- header of the table rendering
- list of "set fields"

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Richard Haeser +1
  • Verified V +2
    • Benni Mack +2
    • Josef Glatz +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1217

  1. Georg Ringer uploaded patch set 1 01/21/19, 10:43

  2. TYPO3com voted on patch set 1 V -1 01/21/19, 10:43 Completed build in 15s on Mon, 21 Jan, 11:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31678

  3. Georg Ringer uploaded patch set 2 01/21/19, 11:23

  4. TYPO3com voted on patch set 2 V +1 01/21/19, 11:34 Completed build in 10m 48s on Mon, 21 Jan, 12:34 PM Test Summary: 46894 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31680

  5. Josef Glatz uploaded patch set 3 01/24/19, 05:02

  6. Josef Glatz updated the commit message in patch set 4 01/24/19, 05:04

  7. Josef Glatz commented on patch set 4 CR -1 01/24/19, 05:08

    on it
  8. TYPO3com voted on patch set 3 V +1 01/24/19, 05:15 Completed build in 13m 06s on Thu, 24 Jan, 06:15 AM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31741

  9. TYPO3com voted on patch set 4 V +1 01/24/19, 05:18 Completed build in 12m 25s on Thu, 24 Jan, 06:18 AM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31742

  10. Josef Glatz uploaded patch set 5 01/24/19, 05:20

  11. Josef Glatz commented on patch set 5 V +1 CR +1 01/24/19, 05:24

    Added support for localized TSConfig overriding in "set fields" list in patch set 5 to get in sync with the TSConfig documentation: TCEFORM.sys_note { subject.label = New Label subject.label.de = Neues Label personal.label = LLL:EXT:core/Resources/Private/Language/locallang_wizards.xlf:imwizard.crop_variant.social personal.label.de = LLL:EXT:core/Resources/Private/Language/locallang_wizards.xlf:imwizard.crop_variant.social }
  12. TYPO3com voted on patch set 5 V +1 01/24/19, 05:40 Completed build in 13m 40s on Thu, 24 Jan, 06:40 AM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31743

  13. Richard Haeser voted on patch set 5 CR +1 01/25/19, 19:20

  14. Riccardo De Contardi voted on patch set 5 V +1 01/25/19, 21:04

  15. Benni Mack voted on patch set 5 V +2 CR +2 01/30/19, 05:47

  16. Benni Mack merged patch set 6 01/30/19, 05:47

  17. Benni Mack commented on patch set 6 01/30/19, 05:47

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 992d8465c32e88b6e15865c370c3a1b1309ae868