59514[!!!][TASK] Remove view related properties from ActionController
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Georg Ringer +1
- Anja Leichsenring +1
- Achim Fritz +1
-
Verified V +2
- Benni Mack +2
- Georg Ringer +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Breaking-87511-RemoveNamespacesViewObjectNamePatternProperty.rstnew+35 −0
- typo3/sysext/core/Documentation/Changelog/master/Breaking-87511-RemoveViewFormatToObjectNameMapProperty.rstnew+35 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −64
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+0 −64
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+10 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+10 −0
Review log 2025
-
Alexander Schnitzler uploaded patch set 1 01/21/19, 16:25
-
TYPO3com voted on patch set 1 V +1 01/21/19, 16:34 Completed build in 09m 32s on Mon, 21 Jan, 05:34 PM Test Summary: 46889 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31697
-
Alexander Schnitzler uploaded patch set 2 01/21/19, 16:47
-
Alexander Schnitzler uploaded patch set 3 01/21/19, 16:52
-
TYPO3com voted on patch set 2 V -1 01/21/19, 16:58 Completed build in 10m 10s on Mon, 21 Jan, 05:58 PM Test Summary: 4 of 47288 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31698
-
TYPO3com voted on patch set 3 V +1 01/21/19, 17:02 Completed build in 10m 03s on Mon, 21 Jan, 06:02 PM Test Summary: 46895 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31699
-
Alexander Schnitzler uploaded patch set 4 01/21/19, 18:08
-
TYPO3com voted on patch set 4 V +1 01/21/19, 18:17 Completed build in 09m 19s on Mon, 21 Jan, 07:17 PM Test Summary: 46895 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31700
-
Alexander Schnitzler wrote 01/22/19, 11:00
Topic set to extbase -
Benjamin Franzke commented on patch set 4 01/22/19, 15:41
Can you describe why this change is necessary, especially why this should be available to be configured using TypoScript? I think a global option like config.tx_extbase.view.viewObjectNamePattern makes no sense, as it breaks every existing view object that adheres to the default pattern – but I figure it's only there to act as default value that MUST NOT be changed, ever. A configuration option with that constraint is not worth to be an option (IMO).How was an action able to set a specific pattern? I mean: The pattern is evaluated before the action is called. Maybe you mean each "controller and initialize*() method"?Deprecation-87511-DeprecateNamespacesViewObjectNamePatternProperty.rst:43Unresolvedpattern -
Alexander Schnitzler commented on patch set 4 V -1 01/23/19, 14:09
Well, this change is not necessary if we want people to have dozens of ways to configure things and overwrite classes. In the end, this and the similar property $viewFormatToObjectNameMap are ways to configure object implementations during runtime. That's something we want to avoid and replace with a proper DI/Configuration in the future. However, I talked to Benni and maybe we will get rid of this thing completely. Therefore, I will put a -1 here myself for now.Reply Unresolved
True, it was only possible to overwrite that per controller, not per action. -
Benjamin Franzke commented on patch set 4 01/23/19, 14:15
Thanks for the information. > maybe we will get rid of this thing completely Yes, I fully agree that removing this is probably best, because moving this to (per database and conditionals configurable) TypoScript will not help with DI, it would make DI even more complicated. -
Alexander Schnitzler commented on patch set 4 01/24/19, 11:02
Any idea how we can keep the functionality while removing the property? The thing is, quite a lot of people use this property to let extbase initialize a JsonView instead of a TemplateView. There are blog posts about it. So, we somehow need to enable people to choose another base view. -
Alexander Schnitzler commented on patch set 4 01/24/19, 11:26
Idea: Simply let people use $defaultViewObjectName instead. It's a first step and not perfect yet but that way we can remove the pattern stuff we need to know vendor and extension name for. That's bs anyway. All we should care about is: Is a class loadable or not. But we don't care where it's actually placed. Conventions are nice but since composer finds everything in any place, let us people decide where to put their classes. We don't need FQCN to directory mappings. -
Alexander Schnitzler commented on patch set 4 01/24/19, 12:05
Sorry, I have mistaken one property for the other. I think it's no problem at all to drop this pattern property along with the format mapping property while leaving the $defaultViewOjectName for now. I'll rewrite this patch. -
Alexander Schnitzler uploaded patch set 5 01/24/19, 12:31
-
TYPO3com voted on patch set 5 V +1 01/24/19, 12:41 Completed build in 10m 39s on Thu, 24 Jan, 01:41 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31744
-
Georg Ringer voted on patch set 5 V +1 CR +1 01/28/19, 20:23
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 01/28/19, 20:23
-
Achim Fritz voted on patch set 5 CR -1 01/29/19, 14:19
-
Alexander Schnitzler commented on patch set 5 01/29/19, 14:30
Would you mind to elaborate on why the -1 is given? -
Achim Fritz wrote 01/30/19, 11:13
Removed Code-Review-1 by Achim Fritz <af@achimfritz.de> -
Achim Fritz commented on patch set 5 CR +1 01/30/19, 11:13
argh, wrong button, sorry -
Benni Mack voted on patch set 5 V +2 CR +2 01/31/19, 06:22
-
Benni Mack merged patch set 6 01/31/19, 06:22